[css-grid] Fix positioning of positioned grid children

[css-grid] Fix positioning of positioned grid children

crrev.com/2543163002 added a potential performance fix to remove extra
layouts of positioned children of grids. The problem that was instead of
just avoiding an extra layout, it was also preventing the code positioning
the children from running. The main consecuence was that all positioned
children were always painted in cell (0,0) of the grid.

BUG=273898
Committed: https://crrev.com/62e83c91f92a640885122b8bf1077d01c63b0609
Cr-Commit-Position: refs/heads/master@{#439459}

[svillar, 2016-12-19 11:46:40]

svillar@igalia.com changed reviewers:
+ jfernandez@igalia.com, rego@igalia.com

[svillar, 2016-12-19 11:46:41]

Sending out for review

[Manuel Rego, 2016-12-19 11:56:07]

lgtm

https://codereview.chromium.org/2582363002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html
(right):

https://codereview.chromium.org/2582363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html:6:
display: grid;
Nit: You don't need this line.

https://codereview.chromium.org/2582363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html:12:
grid-auto-columns: 20px;
I guess you don't need this line.

https://codereview.chromium.org/2582363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html:17:
.abs { height: 5px; position: absolute; width: 100%; }
Nit: Why only 1 line here and not in the other?

https://codereview.chromium.org/2582363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html:21:
height: 30px;
Nit: Indentation here doesn't match the rest of the file.

https://codereview.chromium.org/2582363002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html:25:

The ref-tests usually have a sentence explaining
how to check if the test passes or fails.

[svillar, 2016-12-19 12:04:28]

The CQ bit was checked by svillar@igalia.com

[svillar, 2016-12-19 12:04:28]

The patchset sent to the CQ was uploaded after l-g-t-m from rego@igalia.com
Link to the patchset: https://codereview.chromium.org/2582363002/#ps80001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-12-19 12:04:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 13:28:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482149068280330,
"parent_rev": "1fc19b0fd5182f179ebf07681b4e6e448a0f8cae", "commit_rev":
"a59dc6bbb1619c1a4affdc9d90ec1f24ca9ddb5d"}

[commit-bot: I haz the power, 2016-12-19 13:28:32]

Description was changed from

==========
[css-grid] Fix positioning of positioned grid children

crrev.com/2543163002 added a potential performance fix to remove extra
layouts of positioned children of grids. The problem that was instead of
just avoiding an extra layout, it was also preventing the code positioning
the children from running. The main consecuence was that all positioned
children were always painted in cell (0,0) of the grid.

BUG=273898
==========

to

==========
[css-grid] Fix positioning of positioned grid children

crrev.com/2543163002 added a potential performance fix to remove extra
layouts of positioned children of grids. The problem that was instead of
just avoiding an extra layout, it was also preventing the code positioning
the children from running. The main consecuence was that all positioned
children were always painted in cell (0,0) of the grid.

BUG=273898

Review-Url: https://codereview.chromium.org/2582363002
==========

[commit-bot: I haz the power, 2016-12-19 13:28:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-19 13:31:20]

Description was changed from

==========
[css-grid] Fix positioning of positioned grid children

crrev.com/2543163002 added a potential performance fix to remove extra
layouts of positioned children of grids. The problem that was instead of
just avoiding an extra layout, it was also preventing the code positioning
the children from running. The main consecuence was that all positioned
children were always painted in cell (0,0) of the grid.

BUG=273898

Review-Url: https://codereview.chromium.org/2582363002
==========

to

==========
[css-grid] Fix positioning of positioned grid children

crrev.com/2543163002 added a potential performance fix to remove extra
layouts of positioned children of grids. The problem that was instead of
just avoiding an extra layout, it was also preventing the code positioning
the children from running. The main consecuence was that all positioned
children were always painted in cell (0,0) of the grid.

BUG=273898

Committed: https://crrev.com/62e83c91f92a640885122b8bf1077d01c63b0609
Cr-Commit-Position: refs/heads/master@{#439459}
==========

[commit-bot: I haz the power, 2016-12-19 13:31:21]

Patchset 5 (id:??) landed as
https://crrev.com/62e83c91f92a640885122b8bf1077d01c63b0609
Cr-Commit-Position: refs/heads/master@{#439459}