third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html - Issue 2582363002: [css-grid] Fix positioning of positioned grid children

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children.html

Issue 2582363002: [css-grid] Fix positioning of positioned grid children (Closed)

Patch Set: Improved test v2 Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <link href="resources/grid.css" rel="stylesheet">

	3 <link rel="match" href="grid-paint-positioned-children-expected.html">

	4 <style>

	5 .grid {

	6 display: grid;
	Manuel Rego 2016/12/19 11:56:07 Nit: You don't need this line. Nit: You don't need this line.
	7 border: 2px solid black;

	8 position: relative;

	9 width: 100px;

	10

	11 grid-template-columns: 10px 20px 30px 40px;

	12 grid-auto-columns: 20px;
	Manuel Rego 2016/12/19 11:56:07 I guess you don't need this line. I guess you don't need this line.
	13

	14 padding-top: 10px;

	15 }

	16

	17 .abs { height: 5px; position: absolute; width: 100%; }
	Manuel Rego 2016/12/19 11:56:07 Nit: Why only 1 line here and not in the other? Nit: Why only 1 line here and not in the other?
	18

	19 #item {

	20 width: 90px;

	21 height: 30px;
	Manuel Rego 2016/12/19 11:56:07 Nit: Indentation here doesn't match the rest of th Nit: Indentation here doesn't match the rest of the file.
	22 }

	23

	24 </style>

	25
	Manuel Rego 2016/12/19 11:56:07 The ref-tests usually have a sentence explaining h The ref-tests usually have a sentence explaining how to check if the test passes or fails.
	26 <div class="grid">

	27 <div id="item" style="grid-column: 1 / -1; background: cyan;"></div>

	28 <div class="abs" style="grid-column: 1 / 2; background: purple;"></div>

	29 <div class="abs" style="grid-column: 2 / 3; background: orange;"></div>

	30 <div class="abs" style="grid-column: 3 / 4; background: yellow;"></div>

	31 <div class="abs" style="grid-column: 4 / 5; background: magenta;"></div>

	32 </div>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-paint-positioned-children-expected.html » ('j') | no next file with comments »