Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2582343003: Instant Apps + Offline: Don't attempt to resolve instant app offline. (Closed)

Created:
4 years ago by Maria
Modified:
4 years ago
Reviewers:
fgorski
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant Apps + Offline: Don't attempt to resolve instant app offline. There is no need to do instant apps check when viewing offline pages since we wouldn't be able to load the app without network. BUG=675216 Committed: https://crrev.com/a8c23f0b07dc7b52a87a0fb1d7052d62db1062d0 Cr-Commit-Position: refs/heads/master@{#439649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Maria
4 years ago (2016-12-20 00:19:03 UTC) #2
fgorski
lgtm
4 years ago (2016-12-20 00:40:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582343003/1
4 years ago (2016-12-20 00:47:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 01:19:45 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 01:22:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8c23f0b07dc7b52a87a0fb1d7052d62db1062d0
Cr-Commit-Position: refs/heads/master@{#439649}

Powered by Google App Engine
This is Rietveld 408576698