chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java - Issue 2582343003: Instant Apps + Offline: Don't attempt to resolve instant app offline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

Issue 2582343003: Instant Apps + Offline: Don't attempt to resolve instant app offline. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

index b47373a2526e1c3a89119ad8d2dc8265242f5004..fbd196cdbf0938bcb96fcf3c6f17c6f9e2d101fa 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

@@ -408,7 +408,7 @@ public class WebsiteSettingsPopup implements OnClickListener {

mOpenOnlineButton.setVisibility(View.GONE);

}

- mInstantAppIntent = mIsInternalPage ? null

+ mInstantAppIntent = (mIsInternalPage || isShowingOfflinePage()) ? null

: InstantAppsHandler.getInstance().getInstantAppIntentForUrl(mFullUrl);

if (mInstantAppIntent == null) mInstantAppButton.setVisibility(View.GONE);

« no previous file with comments | « no previous file | no next file » | no next file with comments »