Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2582223002:
Add knowledge of EarlGrey test files to PRESUBMIT.py. (Closed)
DescriptionAdd knowledge of EarlGrey test files to PRESUBMIT.py.
EarlGrey is the framework used for integration tests on iOS and the
corresponding test files are by convention named *_egtest.mm. Add
the pattern to PRESUBMIT.py so that no warning is printed if there
is code calling test functions in those files.
Remove knowledge about KIF test files as this is no longer used.
BUG=666375
Committed: https://crrev.com/1fccb0ab39474f8d297201a443db7d93bba7a9d5
Cr-Commit-Position: refs/heads/master@{#439432}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove support for KIF. #Messages
Total messages: 24 (16 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + dpranke@chromium.org
Please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sdefresne@chromium.org changed reviewers: + rohitrao@chromium.org
lgtm https://codereview.chromium.org/2582223002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/2582223002/diff/1/PRESUBMIT.py#newcode41 PRESUBMIT.py:41: r'.+_(api|browser|eg|kif|perf|pixel|unit|ui)?test(_[a-z]+)?%s' % We could potentially remove kif as well, since we no longer have any kiftest files.
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add knowledge of EarlGrey test files to PRESUBMIT.py. EarlGrey is the framework used for integration tests on iOS and the corresponding test files are by convention named *_egtest.mm. Add the pattern to PRESUBMIT.py so that no warning is printed if there is code calling test functions in those files. BUG=666375 ========== to ========== Add knowledge of EarlGrey test files to PRESUBMIT.py. EarlGrey is the framework used for integration tests on iOS and the corresponding test files are by convention named *_egtest.mm. Add the pattern to PRESUBMIT.py so that no warning is printed if there is code calling test functions in those files. Remove knowledge about KIF test files as this is no longer used. BUG=666375 ==========
Thank you for the review. https://codereview.chromium.org/2582223002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/2582223002/diff/1/PRESUBMIT.py#newcode41 PRESUBMIT.py:41: r'.+_(api|browser|eg|kif|perf|pixel|unit|ui)?test(_[a-z]+)?%s' % On 2016/12/17 17:55:28, rohitrao wrote: > We could potentially remove kif as well, since we no longer have any kiftest > files. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rohitrao@chromium.org Link to the patchset: https://codereview.chromium.org/2582223002/#ps20001 (title: "Remove support for KIF.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482134420359470,
"parent_rev": "7a8d7a5cf045560e33c604830bd2b8a89bc44edd", "commit_rev":
"cd0e540d3d1a2db9eeaf5eb16984b6f34ef440f5"}
Message was sent while issue was closed.
Description was changed from ========== Add knowledge of EarlGrey test files to PRESUBMIT.py. EarlGrey is the framework used for integration tests on iOS and the corresponding test files are by convention named *_egtest.mm. Add the pattern to PRESUBMIT.py so that no warning is printed if there is code calling test functions in those files. Remove knowledge about KIF test files as this is no longer used. BUG=666375 ========== to ========== Add knowledge of EarlGrey test files to PRESUBMIT.py. EarlGrey is the framework used for integration tests on iOS and the corresponding test files are by convention named *_egtest.mm. Add the pattern to PRESUBMIT.py so that no warning is printed if there is code calling test functions in those files. Remove knowledge about KIF test files as this is no longer used. BUG=666375 Review-Url: https://codereview.chromium.org/2582223002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add knowledge of EarlGrey test files to PRESUBMIT.py. EarlGrey is the framework used for integration tests on iOS and the corresponding test files are by convention named *_egtest.mm. Add the pattern to PRESUBMIT.py so that no warning is printed if there is code calling test functions in those files. Remove knowledge about KIF test files as this is no longer used. BUG=666375 Review-Url: https://codereview.chromium.org/2582223002 ========== to ========== Add knowledge of EarlGrey test files to PRESUBMIT.py. EarlGrey is the framework used for integration tests on iOS and the corresponding test files are by convention named *_egtest.mm. Add the pattern to PRESUBMIT.py so that no warning is printed if there is code calling test functions in those files. Remove knowledge about KIF test files as this is no longer used. BUG=666375 Committed: https://crrev.com/1fccb0ab39474f8d297201a443db7d93bba7a9d5 Cr-Commit-Position: refs/heads/master@{#439432} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1fccb0ab39474f8d297201a443db7d93bba7a9d5 Cr-Commit-Position: refs/heads/master@{#439432} |
