Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 20 matching lines...) Expand all Loading... | |
| 31 # Fragment of a regular expression that matches C++ and Objective-C++ | 31 # Fragment of a regular expression that matches C++ and Objective-C++ |
| 32 # implementation files. | 32 # implementation files. |
| 33 _IMPLEMENTATION_EXTENSIONS = r'\.(cc|cpp|cxx|mm)$' | 33 _IMPLEMENTATION_EXTENSIONS = r'\.(cc|cpp|cxx|mm)$' |
| 34 | 34 |
| 35 | 35 |
| 36 # Regular expression that matches code only used for test binaries | 36 # Regular expression that matches code only used for test binaries |
| 37 # (best effort). | 37 # (best effort). |
| 38 _TEST_CODE_EXCLUDED_PATHS = ( | 38 _TEST_CODE_EXCLUDED_PATHS = ( |
| 39 r'.*[\\\/](fake_|test_|mock_).+%s' % _IMPLEMENTATION_EXTENSIONS, | 39 r'.*[\\\/](fake_|test_|mock_).+%s' % _IMPLEMENTATION_EXTENSIONS, |
| 40 r'.+_test_(base|support|util)%s' % _IMPLEMENTATION_EXTENSIONS, | 40 r'.+_test_(base|support|util)%s' % _IMPLEMENTATION_EXTENSIONS, |
| 41 r'.+_(api|browser|kif|perf|pixel|unit|ui)?test(_[a-z]+)?%s' % | 41 r'.+_(api|browser|eg|kif|perf|pixel|unit|ui)?test(_[a-z]+)?%s' % |
|
rohitrao (ping after 24h)
2016/12/17 17:55:28
We could potentially remove kif as well, since we
sdefresne
2016/12/17 20:01:20
Done.
| |
| 42 _IMPLEMENTATION_EXTENSIONS, | 42 _IMPLEMENTATION_EXTENSIONS, |
| 43 r'.+profile_sync_service_harness%s' % _IMPLEMENTATION_EXTENSIONS, | 43 r'.+profile_sync_service_harness%s' % _IMPLEMENTATION_EXTENSIONS, |
| 44 r'.*[\\\/](test|tool(s)?)[\\\/].*', | 44 r'.*[\\\/](test|tool(s)?)[\\\/].*', |
| 45 # content_shell is used for running layout tests. | 45 # content_shell is used for running layout tests. |
| 46 r'content[\\\/]shell[\\\/].*', | 46 r'content[\\\/]shell[\\\/].*', |
| 47 # Non-production example code. | 47 # Non-production example code. |
| 48 r'mojo[\\\/]examples[\\\/].*', | 48 r'mojo[\\\/]examples[\\\/].*', |
| 49 # Launcher for running iOS tests on the simulator. | 49 # Launcher for running iOS tests on the simulator. |
| 50 r'testing[\\\/]iossim[\\\/]iossim\.mm$', | 50 r'testing[\\\/]iossim[\\\/]iossim\.mm$', |
| 51 ) | 51 ) |
| (...skipping 2245 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2297 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 2297 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| 2298 input_api, | 2298 input_api, |
| 2299 output_api, | 2299 output_api, |
| 2300 json_url='http://chromium-status.appspot.com/current?format=json')) | 2300 json_url='http://chromium-status.appspot.com/current?format=json')) |
| 2301 | 2301 |
| 2302 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2302 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 2303 input_api, output_api)) | 2303 input_api, output_api)) |
| 2304 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2304 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 2305 input_api, output_api)) | 2305 input_api, output_api)) |
| 2306 return results | 2306 return results |
| OLD | NEW |