[Command buffer]: Don't blit color buffer if draw buffers have no image during blitting

[Command buffer]: Don't blit color buffer if draw buffers have no image during blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/9880858779bea48a0e826a296b19191dc4c4e12c
Cr-Commit-Position: refs/heads/master@{#440329}

[yunchao, 2016-12-16 09:40:53]

Description was changed from

==========
[Command buffer]: early return if draw fbo have no image during blitting

BUG=
==========

to

==========
[Command buffer]: early return if draw fbo have no image during blitting

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-12-16 15:17:11]

Description was changed from

==========
[Command buffer]: early return if draw fbo have no image during blitting

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer]: early return if draw fbo have no image during blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-12-16 15:17:12]

yunchao.he@intel.com changed reviewers:
+ kbr@chromium.org, oetuaho@nvidia.com, qiankun.miao@intel.com, zmo@chromium.org

[yunchao, 2016-12-16 15:27:26]

Description was changed from

==========
[Command buffer]: early return if draw fbo have no image during blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer]: early return if draw buffers have no image during blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-12-16 15:30:39]

yunchao.he@intel.com changed reviewers:
- oetuaho@nvidia.com

[yunchao, 2016-12-16 15:30:39]

Zhenyao and all: PTAL

Please refer to https://codereview.chromium.org/2570823002/.

[Zhenyao Mo, 2016-12-16 23:50:31]

https://codereview.chromium.org/2581973002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2581973002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:8057: if (draw_framebuffer &&
!draw_buffer_has_image)
You can't return early here.  DEPTH and STENCIL might have images and the mask
might have these bits also.

[yunchao, 2016-12-19 03:16:38]

Description was changed from

==========
[Command buffer]: early return if draw buffers have no image during blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer]: Don't blit color buffer if draw buffers have no image during
blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-12-19 03:20:08]

Thanks for your review, Zhenyao.

https://codereview.chromium.org/2581973002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2581973002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:8057: if (draw_framebuffer &&
!draw_buffer_has_image)
On 2016/12/16 23:50:31, Zhenyao Mo wrote:
> You can't return early here.  DEPTH and STENCIL might have images and the mask
> might have these bits also.

You are correct. I made a mistake here. The code has been updated accordingly,
please take another look, Zhenyao.

[yunchao, 2016-12-21 14:34:20]

Could you take another look, Zhenyao? Thanks a lot!

[Zhenyao Mo, 2016-12-21 22:30:28]

On 2016/12/21 14:34:20, yunchao wrote:
> Could you take another look, Zhenyao? Thanks a lot!

lgtm

[yunchao, 2016-12-22 00:28:37]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 00:29:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 01:47:53]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-12-22 01:53:27]

The CQ bit was checked by yunchao.he@intel.com

[yunchao, 2016-12-22 01:53:28]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2581973002/#ps140001
(title: "code rebase")

[commit-bot: I haz the power, 2016-12-22 01:53:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 03:47:25]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1482371607972710,
"parent_rev": "9c635a3b983cc99c812c1e4f5793986698c2efd9", "commit_rev":
"d19126f654f51bdd2e1ba9bfaed1d60836c8b3b0"}

[commit-bot: I haz the power, 2016-12-22 03:47:55]

Description was changed from

==========
[Command buffer]: Don't blit color buffer if draw buffers have no image during
blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer]: Don't blit color buffer if draw buffers have no image during
blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2581973002
==========

[commit-bot: I haz the power, 2016-12-22 03:47:56]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-12-22 03:51:22]

Description was changed from

==========
[Command buffer]: Don't blit color buffer if draw buffers have no image during
blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2581973002
==========

to

==========
[Command buffer]: Don't blit color buffer if draw buffers have no image during
blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/9880858779bea48a0e826a296b19191dc4c4e12c
Cr-Commit-Position: refs/heads/master@{#440329}
==========

[commit-bot: I haz the power, 2016-12-22 03:51:23]

Patchset 8 (id:??) landed as
https://crrev.com/9880858779bea48a0e826a296b19191dc4c4e12c
Cr-Commit-Position: refs/heads/master@{#440329}