Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 2581943002: Make sure that ServiceWorkerContainer::m_navigator is not null (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
falken, Wez
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure that ServiceWorkerContainer::m_navigator is not null BUG=610176 Committed: https://crrev.com/ffc7eff2d15598709edc6614c97240b369ba229c Cr-Commit-Position: refs/heads/master@{#439424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 6 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
haraken
PTAL As requested by wez@ at https://codereview.chromium.org/2556893003/
4 years ago (2016-12-16 04:49:17 UTC) #2
falken
lgtm BUG=610176 to link it with the other patch?
4 years ago (2016-12-16 04:58:45 UTC) #4
haraken
On 2016/12/16 04:58:45, falken wrote: > lgtm > > BUG=610176 to link it with the ...
4 years ago (2016-12-16 04:59:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581943002/1
4 years ago (2016-12-16 04:59:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/357848)
4 years ago (2016-12-16 07:37:08 UTC) #10
Wez
lgtm
4 years ago (2016-12-17 06:43:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581943002/1
4 years ago (2016-12-19 05:23:20 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 07:40:45 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-19 07:43:11 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffc7eff2d15598709edc6614c97240b369ba229c
Cr-Commit-Position: refs/heads/master@{#439424}

Powered by Google App Engine
This is Rietveld 408576698