Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 2581943002: Make sure that ServiceWorkerContainer::m_navigator is not null (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
index 3ada7d2fd3c43e4f95849aaaaf5a053b582cfd99..beb0093a88123be7d8f633fa9af90b986b1d8daa 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
@@ -16,6 +16,7 @@
#include "core/dom/ExecutionContext.h"
#include "core/page/FocusController.h"
#include "core/testing/DummyPageHolder.h"
+#include "modules/serviceworkers/NavigatorServiceWorker.h"
#include "modules/serviceworkers/ServiceWorkerContainerClient.h"
#include "platform/weborigin/KURL.h"
#include "platform/weborigin/SecurityOrigin.h"
@@ -150,6 +151,9 @@ class ServiceWorkerContainerTest : public ::testing::Test {
}
ExecutionContext* getExecutionContext() { return &(m_page->document()); }
+ NavigatorServiceWorker* getNavigatorServiceWorker() {
+ return NavigatorServiceWorker::from(m_page->document());
+ }
v8::Isolate* isolate() { return v8::Isolate::GetCurrent(); }
ScriptState* getScriptState() {
return ScriptState::forMainWorld(m_page->document().frame());
@@ -176,8 +180,8 @@ class ServiceWorkerContainerTest : public ::testing::Test {
// the provider.
provide(WTF::makeUnique<NotReachedWebServiceWorkerProvider>());
- ServiceWorkerContainer* container =
- ServiceWorkerContainer::create(getExecutionContext(), nullptr);
+ ServiceWorkerContainer* container = ServiceWorkerContainer::create(
+ getExecutionContext(), getNavigatorServiceWorker());
ScriptState::Scope scriptScope(getScriptState());
RegistrationOptions options;
options.setScope(scope);
@@ -190,8 +194,8 @@ class ServiceWorkerContainerTest : public ::testing::Test {
const ScriptValueTest& valueTest) {
provide(WTF::makeUnique<NotReachedWebServiceWorkerProvider>());
- ServiceWorkerContainer* container =
- ServiceWorkerContainer::create(getExecutionContext(), nullptr);
+ ServiceWorkerContainer* container = ServiceWorkerContainer::create(
+ getExecutionContext(), getNavigatorServiceWorker());
ScriptState::Scope scriptScope(getScriptState());
ScriptPromise promise =
container->getRegistration(getScriptState(), documentURL);
@@ -331,8 +335,8 @@ TEST_F(ServiceWorkerContainerTest,
StubWebServiceWorkerProvider stubProvider;
provide(stubProvider.provider());
- ServiceWorkerContainer* container =
- ServiceWorkerContainer::create(getExecutionContext(), nullptr);
+ ServiceWorkerContainer* container = ServiceWorkerContainer::create(
+ getExecutionContext(), getNavigatorServiceWorker());
// register
{
@@ -357,8 +361,8 @@ TEST_F(ServiceWorkerContainerTest,
StubWebServiceWorkerProvider stubProvider;
provide(stubProvider.provider());
- ServiceWorkerContainer* container =
- ServiceWorkerContainer::create(getExecutionContext(), nullptr);
+ ServiceWorkerContainer* container = ServiceWorkerContainer::create(
+ getExecutionContext(), getNavigatorServiceWorker());
{
ScriptState::Scope scriptScope(getScriptState());
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698