Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2581313002: Cleanup DataReductionProxy (DRP) Brotli code (Closed)

Created:
4 years ago by tbansal1
Modified:
4 years ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup DataReductionProxy (DRP) Brotli code Add thread checkers to request options class. Force the generation of the chrome-proxy header, and use it later when generating the MockWrite for the sockets in tests. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=634061 Committed: https://crrev.com/eede5513b6b631647b3cf84e42436ca8b4694294 Cr-Commit-Position: refs/heads/master@{#439260}

Patch Set 1 : Patch from https://codereview.chromium.org/2571993002/ #

Patch Set 2 : Fix thread checker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -69 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 15 chunks +51 lines, -39 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc View 1 3 chunks +13 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h View 5 chunks +11 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc View 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
tbansal1
ryansturm: ptal.
4 years ago (2016-12-16 19:47:33 UTC) #5
RyanSturm
lgtm
4 years ago (2016-12-16 20:20:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581313002/40001
4 years ago (2016-12-16 23:19:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-17 00:45:49 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-17 00:49:17 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eede5513b6b631647b3cf84e42436ca8b4694294
Cr-Commit-Position: refs/heads/master@{#439260}

Powered by Google App Engine
This is Rietveld 408576698