components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc - Issue 2581313002: Cleanup DataReductionProxy (DRP) Brotli code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

Issue 2581313002: Cleanup DataReductionProxy (DRP) Brotli code (Closed)

Patch Set: Fix thread checker Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

index 74d7e3abeb480d0eb2537b9251729370b2dc1026..0a37807e2bb03372e4b2ba1aa9ffa91f3bc69dac 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

@@ -181,8 +181,7 @@ DataReductionProxyNetworkDelegate::DataReductionProxyNetworkDelegate(

data_reduction_proxy_bypass_stats_(nullptr),

data_reduction_proxy_request_options_(request_options),

data_reduction_proxy_io_data_(nullptr),

- configurator_(configurator),

- exclude_chrome_proxy_header_for_testing_(false) {

+ configurator_(configurator) {

DCHECK(data_reduction_proxy_config_);

DCHECK(data_reduction_proxy_request_options_);

DCHECK(configurator_);

@@ -326,8 +325,7 @@ void DataReductionProxyNetworkDelegate::OnBeforeSendHeadersInternal(

}

MaybeAddBrotliToAcceptEncodingHeader(proxy_info, headers, *request);

- if (!exclude_chrome_proxy_header_for_testing_)

- data_reduction_proxy_request_options_->AddRequestHeader(headers);

+ data_reduction_proxy_request_options_->AddRequestHeader(headers);

if (lofi_decider)

lofi_decider->MaybeSetIgnorePreviewsBlacklistDirective(headers);

}