Reland of [DevTools] Migrate target domain to new generator.

Reland of [DevTools] Migrate target domain to new generator. (patchset #1 id:1 of https://codereview.chromium.org/2578303002/ )

Reason for revert:
Fixed crash reason in https://codereview.chromium.org/2579923002/

Original issue's description:
> Revert of [DevTools] Migrate target domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2574843003/ )
>
> Reason for revert:
> Speculative
>
> Original issue's description:
> > [DevTools] Migrate target domain to new generator.
> >
> > BUG=664683
> > TBR=pfeldman
> >
> > Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
> > Cr-Commit-Position: refs/heads/master@{#438733}
>
> TBR=caseq@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664683
>
> Committed: https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e
> Cr-Commit-Position: refs/heads/master@{#438940}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683
Committed: https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf
Cr-Commit-Position: refs/heads/master@{#439035}

[dgozman, 2016-12-16 05:29:23]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-12-16 05:29:23]

Created Reland of [DevTools] Migrate target domain to new generator.

[commit-bot: I haz the power, 2016-12-16 05:29:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 05:31:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481866163469490, "parent_rev":
"274c08db6328cd66c0887c3fe5e249f029838233", "commit_rev":
"216d4b741ed1c0e039a03577fe5c3d8ad5137e50"}

[commit-bot: I haz the power, 2016-12-16 05:33:22]

Description was changed from

==========
Reland of [DevTools] Migrate target domain to new generator. (patchset #1 id:1
of https://codereview.chromium.org/2578303002/ )

Reason for revert:
Fixed crash reason in https://codereview.chromium.org/2579923002/

Original issue's description:
> Revert of [DevTools] Migrate target domain to new generator. (patchset #2
id:20001 of https://codereview.chromium.org/2574843003/ )
> 
> Reason for revert:
> Speculative
> 
> Original issue's description:
> > [DevTools] Migrate target domain to new generator.
> >
> > BUG=664683
> > TBR=pfeldman
> >
> > Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
> > Cr-Commit-Position: refs/heads/master@{#438733}
> 
> TBR=caseq@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664683
> 
> Committed: https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e
> Cr-Commit-Position: refs/heads/master@{#438940}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683
==========

to

==========
Reland of [DevTools] Migrate target domain to new generator. (patchset #1 id:1
of https://codereview.chromium.org/2578303002/ )

Reason for revert:
Fixed crash reason in https://codereview.chromium.org/2579923002/

Original issue's description:
> Revert of [DevTools] Migrate target domain to new generator. (patchset #2
id:20001 of https://codereview.chromium.org/2574843003/ )
>
> Reason for revert:
> Speculative
>
> Original issue's description:
> > [DevTools] Migrate target domain to new generator.
> >
> > BUG=664683
> > TBR=pfeldman
> >
> > Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
> > Cr-Commit-Position: refs/heads/master@{#438733}
>
> TBR=caseq@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664683
>
> Committed: https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e
> Cr-Commit-Position: refs/heads/master@{#438940}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683

Review-Url: https://codereview.chromium.org/2581103002
Committed:
https://chromium.googlesource.com/chromium/src/+/216d4b741ed1c0e039a03577fe5c...
==========

[commit-bot: I haz the power, 2016-12-16 05:33:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/216d4b741ed1c0e039a03577fe5c...

[commit-bot: I haz the power, 2016-12-16 05:36:39]

Description was changed from

==========
Reland of [DevTools] Migrate target domain to new generator. (patchset #1 id:1
of https://codereview.chromium.org/2578303002/ )

Reason for revert:
Fixed crash reason in https://codereview.chromium.org/2579923002/

Original issue's description:
> Revert of [DevTools] Migrate target domain to new generator. (patchset #2
id:20001 of https://codereview.chromium.org/2574843003/ )
>
> Reason for revert:
> Speculative
>
> Original issue's description:
> > [DevTools] Migrate target domain to new generator.
> >
> > BUG=664683
> > TBR=pfeldman
> >
> > Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
> > Cr-Commit-Position: refs/heads/master@{#438733}
>
> TBR=caseq@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664683
>
> Committed: https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e
> Cr-Commit-Position: refs/heads/master@{#438940}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683

Review-Url: https://codereview.chromium.org/2581103002
Committed:
https://chromium.googlesource.com/chromium/src/+/216d4b741ed1c0e039a03577fe5c...
==========

to

==========
Reland of [DevTools] Migrate target domain to new generator. (patchset #1 id:1
of https://codereview.chromium.org/2578303002/ )

Reason for revert:
Fixed crash reason in https://codereview.chromium.org/2579923002/

Original issue's description:
> Revert of [DevTools] Migrate target domain to new generator. (patchset #2
id:20001 of https://codereview.chromium.org/2574843003/ )
>
> Reason for revert:
> Speculative
>
> Original issue's description:
> > [DevTools] Migrate target domain to new generator.
> >
> > BUG=664683
> > TBR=pfeldman
> >
> > Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
> > Cr-Commit-Position: refs/heads/master@{#438733}
>
> TBR=caseq@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664683
>
> Committed: https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e
> Cr-Commit-Position: refs/heads/master@{#438940}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664683

Committed: https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf
Cr-Commit-Position: refs/heads/master@{#439035}
==========

[commit-bot: I haz the power, 2016-12-16 05:36:40]

Patchset 1 (id:??) landed as
https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf
Cr-Commit-Position: refs/heads/master@{#439035}

[Sami, 2016-12-16 18:59:34]

Looks like this made some of our headless tests[1] fail with:

[ RUN      ] TargetDomainCreateTwoContexts.RunAsyncTest
[5524:5549:1216/185704.649169:2098330816144:ERROR:entry.cc(167)]
Entry::Deserialize: dictionary has no interface_provider_specs key
[5524:5524:1216/185705.670030:2098331836957:ERROR:headless_devtools_client_impl.cc(133)]
Error in method call result: {
   "code": -32000,
   "message": "Not supported"
}

../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:211:
pointer std::unique_ptr<headless::target::CreateBrowserContextResult,
std::default_delete<headless::target::CreateBrowserContextResult>
>::operator->() const [_Tp = headless::target::CreateBrowserContextResult, _Dp =
std::default_delete<headless::target::CreateBrowserContextResult>]: Assertion
'get() != pointer()' failed.

Do we need to do something to make sure the target handler exists?

[1]
https://build.chromium.org/p/chromium.fyi/builders/Headless%20Linux%20%28dbg%...

[dgozman, 2016-12-16 20:21:19]

On 2016/12/16 18:59:34, Sami wrote:
> Looks like this made some of our headless tests[1] fail with:
> 
> [ RUN      ] TargetDomainCreateTwoContexts.RunAsyncTest
> [5524:5549:1216/185704.649169:2098330816144:ERROR:entry.cc(167)]
> Entry::Deserialize: dictionary has no interface_provider_specs key
>
[5524:5524:1216/185705.670030:2098331836957:ERROR:headless_devtools_client_impl.cc(133)]
> Error in method call result: {
>    "code": -32000,
>    "message": "Not supported"
> }
> 
>
../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:211:
> pointer std::unique_ptr<headless::target::CreateBrowserContextResult,
> std::default_delete<headless::target::CreateBrowserContextResult>
> >::operator->() const [_Tp = headless::target::CreateBrowserContextResult, _Dp
=
> std::default_delete<headless::target::CreateBrowserContextResult>]: Assertion
> 'get() != pointer()' failed.
> 
> Do we need to do something to make sure the target handler exists?
> 
> [1]
>
https://build.chromium.org/p/chromium.fyi/builders/Headless%20Linux%20%28dbg%...

Interesting... I will take a look. Didn't you add these tests to CQ already?

[Sami, 2016-12-19 10:22:03]

On 2016/12/16 20:21:19, dgozman wrote:
> On 2016/12/16 18:59:34, Sami wrote:
> > Looks like this made some of our headless tests[1] fail with:
> > 
> > [ RUN      ] TargetDomainCreateTwoContexts.RunAsyncTest
> > [5524:5549:1216/185704.649169:2098330816144:ERROR:entry.cc(167)]
> > Entry::Deserialize: dictionary has no interface_provider_specs key
> >
>
[5524:5524:1216/185705.670030:2098331836957:ERROR:headless_devtools_client_impl.cc(133)]
> > Error in method call result: {
> >    "code": -32000,
> >    "message": "Not supported"
> > }
> > 
> >
>
../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:211:
> > pointer std::unique_ptr<headless::target::CreateBrowserContextResult,
> > std::default_delete<headless::target::CreateBrowserContextResult>
> > >::operator->() const [_Tp = headless::target::CreateBrowserContextResult,
_Dp
> =
> > std::default_delete<headless::target::CreateBrowserContextResult>]:
Assertion
> > 'get() != pointer()' failed.
> > 
> > Do we need to do something to make sure the target handler exists?
> > 
> > [1]
> >
>
https://build.chromium.org/p/chromium.fyi/builders/Headless%20Linux%20%28dbg%...
> 
> Interesting... I will take a look. Didn't you add these tests to CQ already?

Thanks for the fix! They're only at 10% cq at the moment. I'll see if I can get
that bumped up.