Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2581103002: Reland of [DevTools] Migrate target domain to new generator. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index ad707efe56c9d39c00a3911b55984035ebf70f0f..76b3866d638974a579b444ec8e8ee4eafc6b3e96 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -395,7 +395,6 @@
RenderFrameHostImpl* host)
: DevToolsAgentHostImpl(base::GenerateGUID()),
input_handler_(new devtools::input::InputHandler()),
- target_handler_(new devtools::target::TargetHandler()),
frame_trace_recorder_(nullptr),
protocol_handler_(new DevToolsProtocolHandler(this)),
handlers_frame_host_(nullptr),
@@ -404,7 +403,6 @@
frame_tree_node_(host->frame_tree_node()) {
DevToolsProtocolDispatcher* dispatcher = protocol_handler_->dispatcher();
dispatcher->SetInputHandler(input_handler_.get());
- dispatcher->SetTargetHandler(target_handler_.get());
SetPending(host);
CommitPending();
@@ -513,6 +511,10 @@
storage_handler_.reset(new protocol::StorageHandler());
storage_handler_->Wire(session()->dispatcher());
storage_handler_->SetRenderFrameHost(handlers_frame_host_);
+
+ target_handler_.reset(new protocol::TargetHandler());
+ target_handler_->Wire(session()->dispatcher());
+ target_handler_->SetRenderFrameHost(handlers_frame_host_);
tracing_handler_.reset(new protocol::TracingHandler(
protocol::TracingHandler::Renderer,
@@ -554,6 +556,8 @@
service_worker_handler_.reset();
storage_handler_->Disable();
storage_handler_.reset();
+ target_handler_->Disable();
+ target_handler_.reset();
tracing_handler_->Disable();
tracing_handler_.reset();
@@ -618,7 +622,6 @@
#if defined(OS_ANDROID)
power_save_blocker_.reset();
#endif
- target_handler_->Detached();
frame_trace_recorder_.reset();
in_navigation_protocol_message_buffer_.clear();
}
@@ -692,7 +695,7 @@
DispatchBufferedProtocolMessagesIfNecessary();
DCHECK(CheckConsistency());
- if (navigation_handle->HasCommitted())
+ if (target_handler_ && navigation_handle->HasCommitted())
target_handler_->UpdateServiceWorkers();
}
@@ -738,7 +741,8 @@
// CommitPending may destruct |this|.
scoped_refptr<RenderFrameDevToolsAgentHost> protect(this);
- target_handler_->UpdateFrames();
+ if (target_handler_)
+ target_handler_->UpdateFrames();
if (IsBrowserSideNavigationEnabled())
return;
@@ -905,7 +909,8 @@
if (pending_ && pending_->host() == render_frame_host)
CommitPending();
DCHECK(CheckConsistency());
- target_handler_->UpdateServiceWorkers();
+ if (target_handler_)
+ target_handler_->UpdateServiceWorkers();
}
void RenderFrameDevToolsAgentHost::DidFailProvisionalLoad(
@@ -972,7 +977,8 @@
security_handler_->SetRenderFrameHost(host);
if (storage_handler_)
storage_handler_->SetRenderFrameHost(host);
- target_handler_->SetRenderFrameHost(host);
+ if (target_handler_)
+ target_handler_->SetRenderFrameHost(host);
}
void RenderFrameDevToolsAgentHost::DisconnectWebContents() {
« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698