Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2581063002: Add IdleSpellCheckCallback to LocalFrame (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IdleSpellCheckCallback to LocalFrame This patch makes each LocalFrame own an IdleSpellCheckCallback. Future patches will make this callback handle spell checking in the frame when IdleTimeSpellChecking is enabled. BUG=517298 Committed: https://crrev.com/f2ebdd3f1db08dbc9876705966986189fde8829a Cr-Commit-Position: refs/heads/master@{#439042}

Patch Set 1 #

Patch Set 2 : Fri Dec 16 12:24:18 JST 2016 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 4 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 3 chunks +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
Xiaocheng
PTAL.
4 years ago (2016-12-16 03:30:27 UTC) #7
tkent
lgtm
4 years ago (2016-12-16 03:55:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581063002/20001
4 years ago (2016-12-16 04:58:02 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 06:13:41 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-16 06:17:53 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f2ebdd3f1db08dbc9876705966986189fde8829a
Cr-Commit-Position: refs/heads/master@{#439042}

Powered by Google App Engine
This is Rietveld 408576698