Let IdleSpellCheckCallback take full control over SpellCheckRequester

Let IdleSpellCheckCallback take full control over SpellCheckRequester

With idle time spell checker, all spell check requests should be managed
solely by IdleSpellCheckCallback. This patch ensures that all access
to spell check requests are via IdleSpellCheckCallback when runtime feature
IdleTimeSpellChecking is enabled, with SpellChecker::cancelCheck being the
only exception. SpellChecker::cancelCheck is only used by unit tests, and
will be changed when unit tests are modified to cope with idle time spell
checker.

BUG=517298
Committed: https://crrev.com/39ef5bad12517b2bbe3b3bcc03eb793c76ed54b2
Cr-Commit-Position: refs/heads/master@{#439076}

[Xiaocheng, 2016-12-15 09:22:09]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 09:22:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 11:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 11:40:35]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-12-16 03:33:32]

Description was changed from

==========
Disallow accessing SpellCheckRequester from SpellChecker when
IdleTimeSpellChecking is enabled

BUG=
==========

to

==========
Let IdleSpellCheckCallback take full control over SpellCheckRequester

With idle time spell checker, all spell check requests should be managed
solely by IdleSpellCheckCallback. This patch ensures that all access
to spell check requests are via IdleSpellCheckCallback when runtime feature
IdleTimeSpellChecking is enabled, with SpellChecker::cancelCheck being the
only exception. SpellChecker::cancelCheck is only used by unit tests, and
will be changed when unit tests are modified to cope with idle time spell
checker.

BUG=517298
==========

[Xiaocheng, 2016-12-16 03:33:37]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 03:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 04:05:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 04:05:44]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Xiaocheng, 2016-12-16 05:11:25]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 05:11:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-12-16 06:18:15]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 06:18:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-12-16 09:12:04]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2016-12-16 09:12:05]

PTAL.

[commit-bot: I haz the power, 2016-12-16 09:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 09:19:43]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-12-16 09:29:37]

lgtm

[Xiaocheng, 2016-12-16 09:33:22]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-12-16 09:33:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 09:37:50]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481880802898610,
"parent_rev": "f3a9e6c1802811a412a64c99ffa56f543ec53365", "commit_rev":
"0e42eac89a237fcb191f6e3c86b04cdb47df9fc0"}

[commit-bot: I haz the power, 2016-12-16 09:38:24]

Description was changed from

==========
Let IdleSpellCheckCallback take full control over SpellCheckRequester

With idle time spell checker, all spell check requests should be managed
solely by IdleSpellCheckCallback. This patch ensures that all access
to spell check requests are via IdleSpellCheckCallback when runtime feature
IdleTimeSpellChecking is enabled, with SpellChecker::cancelCheck being the
only exception. SpellChecker::cancelCheck is only used by unit tests, and
will be changed when unit tests are modified to cope with idle time spell
checker.

BUG=517298
==========

to

==========
Let IdleSpellCheckCallback take full control over SpellCheckRequester

With idle time spell checker, all spell check requests should be managed
solely by IdleSpellCheckCallback. This patch ensures that all access
to spell check requests are via IdleSpellCheckCallback when runtime feature
IdleTimeSpellChecking is enabled, with SpellChecker::cancelCheck being the
only exception. SpellChecker::cancelCheck is only used by unit tests, and
will be changed when unit tests are modified to cope with idle time spell
checker.

BUG=517298

Review-Url: https://codereview.chromium.org/2580773002
==========

[commit-bot: I haz the power, 2016-12-16 09:38:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-16 09:40:13]

Description was changed from

==========
Let IdleSpellCheckCallback take full control over SpellCheckRequester

With idle time spell checker, all spell check requests should be managed
solely by IdleSpellCheckCallback. This patch ensures that all access
to spell check requests are via IdleSpellCheckCallback when runtime feature
IdleTimeSpellChecking is enabled, with SpellChecker::cancelCheck being the
only exception. SpellChecker::cancelCheck is only used by unit tests, and
will be changed when unit tests are modified to cope with idle time spell
checker.

BUG=517298

Review-Url: https://codereview.chromium.org/2580773002
==========

to

==========
Let IdleSpellCheckCallback take full control over SpellCheckRequester

With idle time spell checker, all spell check requests should be managed
solely by IdleSpellCheckCallback. This patch ensures that all access
to spell check requests are via IdleSpellCheckCallback when runtime feature
IdleTimeSpellChecking is enabled, with SpellChecker::cancelCheck being the
only exception. SpellChecker::cancelCheck is only used by unit tests, and
will be changed when unit tests are modified to cope with idle time spell
checker.

BUG=517298

Committed: https://crrev.com/39ef5bad12517b2bbe3b3bcc03eb793c76ed54b2
Cr-Commit-Position: refs/heads/master@{#439076}
==========

[commit-bot: I haz the power, 2016-12-16 09:40:13]

Patchset 5 (id:??) landed as
https://crrev.com/39ef5bad12517b2bbe3b3bcc03eb793c76ed54b2
Cr-Commit-Position: refs/heads/master@{#439076}