Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2581003002: DevTools: remove extra options from Timeline Advanced mode. (Closed)

Created:
4 years ago by alph
Modified:
4 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove extra options from Timeline Advanced mode. BUG=570441 Committed: https://crrev.com/4296cd332ce4c950aa039fbd1230bfaf1c5aa416 Cr-Commit-Position: refs/heads/master@{#438997}

Patch Set 1 #

Patch Set 2 : Bring back JavaScript option #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -26 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js View 1 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js View 1 5 chunks +5 lines, -23 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
alph
4 years ago (2016-12-15 22:07:01 UTC) #2
pfeldman
lgtm
4 years ago (2016-12-15 22:24:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581003002/1
4 years ago (2016-12-15 22:25:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/123868) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-15 22:28:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581003002/20001
4 years ago (2016-12-16 00:16:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 03:15:43 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-16 03:17:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4296cd332ce4c950aa039fbd1230bfaf1c5aa416
Cr-Commit-Position: refs/heads/master@{#438997}

Powered by Google App Engine
This is Rietveld 408576698