Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Issue 2581003002: DevTools: remove extra options from Timeline Advanced mode. (Closed)
Patch Set: Bring back JavaScript option Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
index d189476dc08107c8e0a4dc3997d0f44d3c6b3cb3..401d4314ed2935cb43b0be7156da5d8ce3748746 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
@@ -33,10 +33,14 @@ Timeline.TimelineController = class {
startRecording(options, providers) {
this._extensionTraceProviders = Extensions.extensionServer.traceProviders().slice();
+ /**
+ * @param {string} category
+ * @return {string}
+ */
function disabledByDefault(category) {
return 'disabled-by-default-' + category;
}
- var categoriesArray = [
+ const categoriesArray = [
'-*', 'devtools.timeline', 'v8.execute', disabledByDefault('devtools.timeline'),
disabledByDefault('devtools.timeline.frame'), SDK.TracingModel.TopLevelEventCategory,
TimelineModel.TimelineModel.Category.Console, TimelineModel.TimelineModel.Category.UserTiming
@@ -64,8 +68,7 @@ Timeline.TimelineController = class {
this._extensionSessions = providers.map(provider => new Timeline.ExtensionTracingSession(provider, this._delegate));
this._extensionSessions.forEach(session => session.start());
- var categories = categoriesArray.join(',');
- this._startRecordingWithCategories(categories, options.enableJSSampling);
+ this._startRecordingWithCategories(categoriesArray.join(','), options.enableJSSampling);
}
stopRecording() {
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698