Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2580973002: Base64-decode encoded ppds from the quirksserver, and update tests. (Closed)

Created:
4 years ago by Carlson
Modified:
4 years ago
Reviewers:
skau
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Base64-decode encoded ppds from the quirksserver, and update tests. BUG=674699 Committed: https://crrev.com/9d98839d33ca4605963e81d8749a00f735c7a4b2 Cr-Commit-Position: refs/heads/master@{#439157}

Patch Set 1 #

Patch Set 2 : Fix some comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chromeos/printing/ppd_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/printing/ppd_provider_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Carlson
4 years ago (2016-12-16 17:10:08 UTC) #3
skau
lgtm
4 years ago (2016-12-16 17:31:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580973002/20001
4 years ago (2016-12-16 17:33:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 18:35:14 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-16 18:37:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d98839d33ca4605963e81d8749a00f735c7a4b2
Cr-Commit-Position: refs/heads/master@{#439157}

Powered by Google App Engine
This is Rietveld 408576698