Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: chromeos/printing/ppd_provider.cc

Issue 2580973002: Base64-decode encoded ppds from the quirksserver, and update tests. (Closed)
Patch Set: Fix some comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/printing/ppd_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/printing/ppd_provider.cc
diff --git a/chromeos/printing/ppd_provider.cc b/chromeos/printing/ppd_provider.cc
index 1d85f0a339ec6a2c633331cb3bf0af3b637bf379..f05b53f0d294e5f0747e6f39e9dabd24fb6f1b35 100644
--- a/chromeos/printing/ppd_provider.cc
+++ b/chromeos/printing/ppd_provider.cc
@@ -7,6 +7,7 @@
#include <unordered_map>
#include <utility>
+#include "base/base64.h"
#include "base/bind_helpers.h"
#include "base/files/file_util.h"
#include "base/json/json_parser.h"
@@ -308,7 +309,7 @@ class PpdProviderImpl : public PpdProvider {
ppd_contents->clear();
return false;
}
- return true;
+ return base::Base64Decode(*ppd_contents, ppd_contents);
}
// Return the ResolveFetchData associated with |source|.
« no previous file with comments | « no previous file | chromeos/printing/ppd_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698