Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2580943002: Fix negative gtest filters for instrumentation tests. (Closed)

Created:
4 years ago by mikecase (-- gone --)
Modified:
4 years ago
Reviewers:
jbudorick
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix negative gtest filters for instrumentation tests. BUG=623047 Committed: https://crrev.com/7ea0ee47f0a67a13f8ac46d8ab1c15f8abba8ac4 Cr-Commit-Position: refs/heads/master@{#438914}

Patch Set 1 #

Patch Set 2 : Reenabled test for negative filters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 chunk +9 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance_test.py View 1 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
mikecase (-- gone --)
4 years ago (2016-12-15 19:21:14 UTC) #2
mikecase (-- gone --)
This basically moves some of the logic from... https://cs.chromium.org/chromium/src/build/util/lib/common/unittest_util.py?q=unittest_util+FilterTest&sq=package:chromium&dr=CSs&l=131 into the instrumenation_test_instance
4 years ago (2016-12-15 19:22:56 UTC) #3
jbudorick
We've got some tests for the filter logic in instrumentation_test_instance_test.py. Mind adding another one or ...
4 years ago (2016-12-15 19:28:29 UTC) #4
mikecase (-- gone --)
re-enabled test and formatted it similar to the other existing tests.
4 years ago (2016-12-15 19:40:21 UTC) #6
jbudorick
lgtm w/ nit: fix the spelling of instrumentation in the title
4 years ago (2016-12-15 19:42:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580943002/20001
4 years ago (2016-12-15 19:45:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 20:40:22 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 20:42:35 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ea0ee47f0a67a13f8ac46d8ab1c15f8abba8ac4
Cr-Commit-Position: refs/heads/master@{#438914}

Powered by Google App Engine
This is Rietveld 408576698