Fix negative gtest filters for instrumentation tests.

build/android/pylib/instrumentation/instrumentation_test_instance_test.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for instrumentation_test_instance."""
 
 # pylint: disable=protected-access
 
 import unittest
@@ skipping 169 matching lines @@
     ]
 
     o._test_filter = 'org.chromium.test.SampleTest2.*'
     o._test_jar = 'path/to/test.jar'
     with mock.patch(_INSTRUMENTATION_TEST_INSTANCE_PATH % '_GetTestsFromPickle',
                     return_value=raw_tests):
       actual_tests = o.GetTests()
 
     self.assertEquals(actual_tests, expected_tests)
 
-  @unittest.skip('crbug.com/623047')
   def testGetTests_negativeGtestFilter(self):
     o = self.createTestInstance()
     raw_tests = [
       {
         'annotations': {'Feature': {'value': ['Foo']}},
         'class': 'org.chromium.test.SampleTest',
         'methods': [
           {
             'annotations': {'SmallTest': None},
             'method': 'testMethod1',
           },
           {
             'annotations': {'MediumTest': None},
             'method': 'testMethod2',
           },
         ],
       },
       {
         'annotations': {'Feature': {'value': ['Bar']}},
         'class': 'org.chromium.test.SampleTest2',
         'methods': [
           {
             'annotations': {'SmallTest': None},
             'method': 'testMethod1',
           },
         ],
       }
     ]
 
-    o._GetTestsFromPickle = mock.MagicMock(return_value=raw_tests)
-    o._test_filter = '*-org.chromium.test.SampleTest.testMethod1'
-    o._test_jar = 'path/to/test.jar'
     expected_tests = [
       {
         'annotations': {
           'Feature': {'value': ['Foo']},
           'MediumTest': None,
         },
         'class': 'org.chromium.test.SampleTest',
         'method': 'testMethod2',
       },
       {
         'annotations': {
           'Feature': {'value': ['Bar']},
           'SmallTest': None,
         },
         'class': 'org.chromium.test.SampleTest2',
         'method': 'testMethod1',
       },
     ]
 
-    actual_tests = o.GetTests()
+    o._test_filter = '*-org.chromium.test.SampleTest.testMethod1'
+    o._test_jar = 'path/to/test.jar'
+    with mock.patch(_INSTRUMENTATION_TEST_INSTANCE_PATH % '_GetTestsFromPickle',
+                    return_value=raw_tests):
+      actual_tests = o.GetTests()
+
     self.assertEquals(actual_tests, expected_tests)
 
   def testGetTests_annotationFilter(self):
     o = self.createTestInstance()
     raw_tests = [
       {
         'annotations': {'Feature': {'value': ['Foo']}},
         'class': 'org.chromium.test.SampleTest',
         'methods': [
           {
@@ skipping 366 matching lines @@
       }),
     ]
     results = instrumentation_test_instance.GenerateTestResults(
         None, None, statuses, 0, 1000)
     self.assertEqual(1, len(results))
     self.assertEqual(base_test_result.ResultType.SKIP, results[0].GetType())
 
 
 if __name__ == '__main__':
   unittest.main(verbosity=2)