Issue 258073004: Require commas between items in a GN list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258073004: Require commas between items in a GN list. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Require commas between items in a GN list. Fixing this issue exposed a race condition in .gni processing where an error parsing a file that another thread was waiting for wouldn't signal that other thread that the load was complete, so it would wait forever. This patch separates out the loading from the signaling in the InputFileManager so we can't forget to do this. BUG=368019 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266976

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -55 lines)			Patch
M	net/BUILD.gn	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/input_file_manager.cc	View	1	4 chunks	+73 lines, -50 lines	0 comments	Download
M	tools/gn/parser.cc	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	tools/gn/parser_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/gn/secondary/tools/grit/grit_rule.gni	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/BUILD.gn	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r266976.

Expand Messages | Collapse Messages