tools/gn/secondary/tools/grit/grit_rule.gni - Issue 258073004: Require commas between items in a GN list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/secondary/tools/grit/grit_rule.gni

Issue 258073004: Require commas between items in a GN list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/secondary/tools/grit/grit_rule.gni

diff --git a/tools/gn/secondary/tools/grit/grit_rule.gni b/tools/gn/secondary/tools/grit/grit_rule.gni

index 89c7b8f9ec4039d99903142950466f0625ba6a71..789e40ea94c65f7a3be4ef9fca62f7b2532750e4 100644

--- a/tools/gn/secondary/tools/grit/grit_rule.gni

+++ b/tools/gn/secondary/tools/grit/grit_rule.gni

@@ -38,7 +38,7 @@ template("grit") {

[ "--inputs", source_path, "-f", resource_ids] + grit_flags, "list lines")

# The inputs are relative to the current (build) directory, rebase to

# the current one.

- grit_inputs = rebase_path(grit_inputs_build_rel, "." root_build_dir)

+ grit_inputs = rebase_path(grit_inputs_build_rel, ".", root_build_dir)

grit_outputs_build_rel = exec_script(grit_info_script,

[ "--outputs", "$output_dir", source_path, "-f", resource_ids ] +

« no previous file with comments | « tools/gn/parser_unittest.cc ('k') | ui/gfx/BUILD.gn » ('j') | no next file with comments »