tools/gn/parser_unittest.cc - Issue 258073004: Require commas between items in a GN list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/parser_unittest.cc

Issue 258073004: Require commas between items in a GN list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/parser_unittest.cc

diff --git a/tools/gn/parser_unittest.cc b/tools/gn/parser_unittest.cc

index adb8fdb4be584a989d1b5f1f8bb1f2aaee4937c9..1205038a8bccf7cf92b1c04c598ac5425cb48014 100644

--- a/tools/gn/parser_unittest.cc

+++ b/tools/gn/parser_unittest.cc

@@ -125,6 +125,7 @@ TEST(Parser, FunctionCall) {

" LITERAL(1)\n"

" LITERAL(2)\n");

DoExpressionErrorTest("foo(1, 2,)", 1, 10);

+ DoExpressionErrorTest("foo(1 2)", 1, 7);

}

TEST(Parser, ParenExpression) {

« no previous file with comments | « tools/gn/parser.cc ('k') | tools/gn/secondary/tools/grit/grit_rule.gni » ('j') | no next file with comments »