Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2580623003: Reland of Whitespace change to test gnumbd shutdown - CQ (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
Reviewers:
tandrii(chromium)
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Whitespace change to test gnumbd shutdown - CQ (patchset #1 id:1 of https://codereview.chromium.org/2583443002/ ) Reason for revert: Test reland Original issue's description: > Revert of Whitespace change to test gnumbd shutdown - CQ (patchset #1 id:1 of https://codereview.chromium.org/2579733002/ ) > > Reason for revert: > Test revert > > Original issue's description: > > Whitespace change to test gnumbd shutdown - CQ > > > > BUG=chromium:674448 > > NOTRY=true > > NOPRESUBMIT=true > > NOTREECHECKS=true > > TBR=tandrii@chromium.org > > > > Review-Url: https://codereview.chromium.org/2579733002 > > Cr-Commit-Position: refs/heads/master@{#41710} > > Committed: https://chromium.googlesource.com/v8/v8/+/47f8979d12543f814eddad990544447d4f95053c > > TBR=tandrii@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:674448 > > Review-Url: https://codereview.chromium.org/2583443002 > Cr-Commit-Position: refs/heads/master@{#41711} > Committed: https://chromium.googlesource.com/v8/v8/+/4619fbe42a91de67abe4f794cf67274035776d84 TBR=tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:674448 Review-Url: https://codereview.chromium.org/2580623003 Cr-Commit-Position: refs/heads/master@{#41712} Committed: https://chromium.googlesource.com/v8/v8/+/b02fd88d75c44c0e88fd083076512c82a5f78adb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/whitespace.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Reland of Whitespace change to test gnumbd shutdown - CQ
4 years ago (2016-12-15 10:12:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580623003/1
4 years ago (2016-12-15 10:12:12 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-15 10:12:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b02fd88d75c44c0e88fd083076512c82a5f...

Powered by Google App Engine
This is Rietveld 408576698