Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2583443002: Revert of Whitespace change to test gnumbd shutdown - CQ (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
Reviewers:
tandrii(chromium)
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Whitespace change to test gnumbd shutdown - CQ (patchset #1 id:1 of https://codereview.chromium.org/2579733002/ ) Reason for revert: Test revert Original issue's description: > Whitespace change to test gnumbd shutdown - CQ > > BUG=chromium:674448 > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > TBR=tandrii@chromium.org > > Review-Url: https://codereview.chromium.org/2579733002 > Cr-Commit-Position: refs/heads/master@{#41710} > Committed: https://chromium.googlesource.com/v8/v8/+/47f8979d12543f814eddad990544447d4f95053c TBR=tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:674448 Review-Url: https://codereview.chromium.org/2583443002 Cr-Commit-Position: refs/heads/master@{#41711} Committed: https://chromium.googlesource.com/v8/v8/+/4619fbe42a91de67abe4f794cf67274035776d84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/whitespace.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Whitespace change to test gnumbd shutdown - CQ
4 years ago (2016-12-15 10:10:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583443002/1
4 years ago (2016-12-15 10:10:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/4619fbe42a91de67abe4f794cf67274035776d84
4 years ago (2016-12-15 10:11:05 UTC) #6
Michael Achenbach
4 years ago (2016-12-15 10:12:05 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2580623003/ by machenbach@chromium.org.

The reason for reverting is: Test reland.

Powered by Google App Engine
This is Rietveld 408576698