Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2580533002: [stubs] Remove CSA::INTEGER_PARAMETERS in favor of CSA::INTPTR_PARAMETERS. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Remove CSA::INTEGER_PARAMETERS in favor of CSA::INTPTR_PARAMETERS. BUG= Review-Url: https://codereview.chromium.org/2580533002 Cr-Commit-Position: refs/heads/master@{#41722} Committed: https://chromium.googlesource.com/v8/v8/+/f1441384ff3800885e5c6f074656bf8806986ff4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -262 lines) Patch
M src/builtins/builtins-array.cc View 15 chunks +27 lines, -33 lines 0 comments Download
M src/builtins/builtins-conversion.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/builtins-function.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/builtins/builtins-internal.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/builtins/builtins-promise.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 15 chunks +16 lines, -32 lines 0 comments Download
M src/code-stub-assembler.h View 9 chunks +32 lines, -39 lines 0 comments Download
M src/code-stub-assembler.cc View 25 chunks +47 lines, -72 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M src/ic/accessor-assembler.cc View 10 chunks +23 lines, -28 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M src/interpreter/interpreter.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 8 chunks +11 lines, -16 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (16 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-14 22:39:02 UTC) #6
Jakob Kummerow
lgtm https://codereview.chromium.org/2580533002/diff/20001/src/interpreter/interpreter-assembler.cc File src/interpreter/interpreter-assembler.cc (right): https://codereview.chromium.org/2580533002/diff/20001/src/interpreter/interpreter-assembler.cc#newcode1263 src/interpreter/interpreter-assembler.cc:1263: StoreFixedArrayElement(array, index, value, UPDATE_WRITE_BARRIER); nit: UPDATE_WRITE_BARRIER is the ...
4 years ago (2016-12-14 23:42:36 UTC) #9
Igor Sheludko
Ross, PTAL @ interpreter https://codereview.chromium.org/2580533002/diff/20001/src/interpreter/interpreter-assembler.cc File src/interpreter/interpreter-assembler.cc (right): https://codereview.chromium.org/2580533002/diff/20001/src/interpreter/interpreter-assembler.cc#newcode1263 src/interpreter/interpreter-assembler.cc:1263: StoreFixedArrayElement(array, index, value, UPDATE_WRITE_BARRIER); On ...
4 years ago (2016-12-14 23:46:09 UTC) #11
rmcilroy
Interpreter LGTM, thanks!
4 years ago (2016-12-15 10:31:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580533002/40001
4 years ago (2016-12-15 13:59:31 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-15 14:01:12 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/f1441384ff3800885e5c6f074656bf88069...

Powered by Google App Engine
This is Rietveld 408576698