[stubs] Enable machine graph verification for CodeStubAssembler and friends by default in debug mode

[stubs] Enable machine graph verification for CodeStubAssembler and friends by default in debug mode.

BUG=

Review-Url: https://codereview.chromium.org/2570213002
Cr-Commit-Position: refs/heads/master@{#41715}
Committed: https://chromium.googlesource.com/v8/v8/+/b5925c0ad0a73dc71f98ddae8a227528a628511f

[Igor Sheludko, 2016-12-14 00:37:21]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-12-14 00:39:23]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-12-14 08:55:33]

Description was changed from

==========
[stubs] Enable machine graph verification for all stubs and builtins.

This CL also cleans up FastAccessorAssembler.

BUG=
==========

to

==========
[stubs] Enable machine graph verification for all stubs and builtins.

BUG=
==========

[Igor Sheludko, 2016-12-14 08:55:45]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-12-14 08:56:23]

Description was changed from

==========
[stubs] Enable machine graph verification for all stubs and builtins.

BUG=
==========

to

==========
[stubs] Enable machine graph verification for CodeStubAssembler by default in
debug mode.

BUG=
==========

[Igor Sheludko, 2016-12-14 09:00:36]

Patchset #1 (id:60001) has been deleted

[Igor Sheludko, 2016-12-14 09:00:57]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 09:01:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 09:22:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 09:22:09]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/19356)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[Igor Sheludko, 2016-12-14 11:04:26]

Patchset #1 (id:80001) has been deleted

[Igor Sheludko, 2016-12-14 11:04:45]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 11:04:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-12-14 11:05:01]

Description was changed from

==========
[stubs] Enable machine graph verification for CodeStubAssembler by default in
debug mode.

BUG=
==========

to

==========
[stubs] Enable machine graph verification for CodeStubAssembler and friends by
default in debug mode.

BUG=
==========

[commit-bot: I haz the power, 2016-12-14 11:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 11:24:24]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/17773)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Igor Sheludko, 2016-12-14 15:41:17]

Patchset #2 (id:120001) has been deleted

[Igor Sheludko, 2016-12-14 15:42:23]

Patchset #1 (id:100001) has been deleted

[Igor Sheludko, 2016-12-14 15:43:04]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 15:43:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-12-14 15:45:36]

ishell@chromium.org changed reviewers:
+ epertoso@chromium.org

[Igor Sheludko, 2016-12-14 15:45:37]

PTAL

https://codereview.chromium.org/2570213002/diff/140001/test/cctest/test-code-...
File test/cctest/test-code-stub-assembler.cc (left):

https://codereview.chromium.org/2570213002/diff/140001/test/cctest/test-code-...
test/cctest/test-code-stub-assembler.cc:1222: TEST(DeferredCodePhiHints) {
I moved this whole red block to test-code-assembler.cc, updated Variable and
Label typedefs and updated the callsites of SmiFromWord32() and
UndefinedConstant() since these methods do not exist in CodeAssembler().

[commit-bot: I haz the power, 2016-12-14 16:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:08:08]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-12-14 17:57:10]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-12-14 17:57:11]

intrepreter/ LGTM (didnt' look at the rest)

[epertoso, 2016-12-15 09:14:37]

lgtm

[Igor Sheludko, 2016-12-15 11:43:11]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-12-15 11:43:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 11:45:19]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1481802191857780,
"parent_rev": "ae741d042c834d2296769e04c27d6b2d4f6e469b", "commit_rev":
"b5925c0ad0a73dc71f98ddae8a227528a628511f"}

[commit-bot: I haz the power, 2016-12-15 11:45:25]

Description was changed from

==========
[stubs] Enable machine graph verification for CodeStubAssembler and friends by
default in debug mode.

BUG=
==========

to

==========
[stubs] Enable machine graph verification for CodeStubAssembler and friends by
default in debug mode.

BUG=

Review-Url: https://codereview.chromium.org/2570213002
Cr-Commit-Position: refs/heads/master@{#41715}
Committed:
https://chromium.googlesource.com/v8/v8/+/b5925c0ad0a73dc71f98ddae8a227528a62...
==========

[commit-bot: I haz the power, 2016-12-15 11:45:26]

Committed patchset #1 (id:140001) as
https://chromium.googlesource.com/v8/v8/+/b5925c0ad0a73dc71f98ddae8a227528a62...