Always use html_diff to generate -pretty-diff.html files.

Always use html_diff to generate -pretty-diff.html files.

The idea of this patch is to start using html_diff for -pretty-diff.html
files; once these files are always available then the wdiff-related code
can be removed and there will still be some kind of HTML diff on Windows.

In order to keep this change minimal, the files are still called
-pretty-diff.html and "has_pretty_patch" is still set in the results JSON,
but after this, the "has_pretty_patch" and "has_wdiff" keys in the results
JSON should be removed.

BUG=672651
Committed: https://crrev.com/498957556586803f87827652555e1b29d7b4866a
Cr-Commit-Position: refs/heads/master@{#440765}

[qyearsley, 2016-12-19 23:07:54]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-12-20 22:23:34]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[qyearsley, 2016-12-20 22:23:39]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:24:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 01:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 01:25:00]

Dry run: This issue passed the CQ dry run.

[jeffcarp, 2016-12-22 22:37:07]

On 2016/12/20 at 22:23:40, qyearsley wrote:
> 

lgtm

> the files are still called -pretty-diff.html and "has_pretty_patch" is still
set in the results JSON

What relies on that file / that key?

[qyearsley, 2016-12-22 22:49:54]

On 2016/12/22 at 22:37:07, jeffcarp wrote:
> On 2016/12/20 at 22:23:40, qyearsley wrote:
> > 
> 
> lgtm
> 
> > the files are still called -pretty-diff.html and "has_pretty_patch" is still
set in the results JSON
> 
> What relies on that file / that key?

The files are output with the layout test results (along with actual results and
text diffs and image diffs), and links are added into the results.html file.

The main thing that looks at that key is results.html, which uses it to decide
whether to display links to pretty-diff.html files
(https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/harn...).

The other thing that looks at it is the test-results app (aka "the flakiness
dashboard" (test-results.appspot.com/dashboards/flakiness_dashboard.html), which
looks at it but apparently doesn't use it as far as I can tell
(https://cs.chromium.org/chromium/infra/go/src/infra/appengine/test-results/mo...).


So, it would be possible to remove that key in this CL from results.html, but
that could also be done in a separate smaller CL, which I think might be easier
to review.

[qyearsley, 2016-12-22 22:49:58]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 22:50:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 23:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 23:55:03]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-12-27 17:12:51]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 17:13:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 18:12:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 18:12:18]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-12-27 18:13:32]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-12-27 18:13:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 18:16:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482862412154730, "parent_rev":
"814a403c8a0e919ae6e2ca44e70e1d950d2a2fad", "commit_rev":
"50440fd9c294e0db13496c25d0ba3adb5b7f60fb"}

[commit-bot: I haz the power, 2016-12-27 18:17:22]

Description was changed from

==========
Always use html_diff to generate -pretty-diff.html files.

The idea of this patch is to start using html_diff for -pretty-diff.html
files; once these files are always available then the wdiff-related code
can be removed and there will still be some kind of HTML diff on Windows.

In order to keep this change minimal, the files are still called
-pretty-diff.html and "has_pretty_patch" is still set in the results JSON,
but after this, the "has_pretty_patch" and "has_wdiff" keys in the results
JSON should be removed.

BUG=672651
==========

to

==========
Always use html_diff to generate -pretty-diff.html files.

The idea of this patch is to start using html_diff for -pretty-diff.html
files; once these files are always available then the wdiff-related code
can be removed and there will still be some kind of HTML diff on Windows.

In order to keep this change minimal, the files are still called
-pretty-diff.html and "has_pretty_patch" is still set in the results JSON,
but after this, the "has_pretty_patch" and "has_wdiff" keys in the results
JSON should be removed.

BUG=672651

Review-Url: https://codereview.chromium.org/2580343003
==========

[commit-bot: I haz the power, 2016-12-27 18:17:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-02 15:46:29]

Description was changed from

==========
Always use html_diff to generate -pretty-diff.html files.

The idea of this patch is to start using html_diff for -pretty-diff.html
files; once these files are always available then the wdiff-related code
can be removed and there will still be some kind of HTML diff on Windows.

In order to keep this change minimal, the files are still called
-pretty-diff.html and "has_pretty_patch" is still set in the results JSON,
but after this, the "has_pretty_patch" and "has_wdiff" keys in the results
JSON should be removed.

BUG=672651

Review-Url: https://codereview.chromium.org/2580343003
==========

to

==========
Always use html_diff to generate -pretty-diff.html files.

The idea of this patch is to start using html_diff for -pretty-diff.html
files; once these files are always available then the wdiff-related code
can be removed and there will still be some kind of HTML diff on Windows.

In order to keep this change minimal, the files are still called
-pretty-diff.html and "has_pretty_patch" is still set in the results JSON,
but after this, the "has_pretty_patch" and "has_wdiff" keys in the results
JSON should be removed.

BUG=672651

Committed: https://crrev.com/498957556586803f87827652555e1b29d7b4866a
Cr-Commit-Position: refs/heads/master@{#440765}
==========

[commit-bot: I haz the power, 2017-01-02 15:46:30]

Patchset 1 (id:??) landed as
https://crrev.com/498957556586803f87827652555e1b29d7b4866a
Cr-Commit-Position: refs/heads/master@{#440765}