third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py - Issue 2580343003: Always use html_diff to generate -pretty-diff.html files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

Issue 2580343003: Always use html_diff to generate -pretty-diff.html files. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

index 35706f7a6b195259a55688b5d4c65d182723908c..e58a5de3176445a43dcd01181edc5273c29e7acc 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

@@ -329,7 +329,7 @@ def summarize_results(port_obj, expectations, initial_results,

results['interrupted'] = initial_results.interrupted

results['layout_tests_dir'] = port_obj.layout_tests_dir()

results['has_wdiff'] = port_obj.wdiff_available()

- results['has_pretty_patch'] = port_obj.pretty_patch_available()

+ results['has_pretty_patch'] = True

results['pixel_tests_enabled'] = port_obj.get_option('pixel_tests')

results['seconds_since_epoch'] = int(time.time())

results['build_number'] = port_obj.get_option('build_number')

@@ -337,6 +337,9 @@ def summarize_results(port_obj, expectations, initial_results,

if port_obj.get_option('order') == 'random':

results['random_order_seed'] = port_obj.get_option('seed')

results['path_delimiter'] = '/'

+ # The pretty-diff.html files should always be available.

+ # TODO(qyearsley): Change this key since PrettyPatch.rb has been removed.

+ results['has_pretty_patch'] = True

# Don't do this by default since it takes >100ms.

# It's only used for rebaselining and uploading data to the flakiness dashboard.