Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2580313002:
Make sanitizer suppressions and blacklists fully configurable. (Closed)
|
Created:
4 years ago by kjellander_chromium Modified:
4 years ago CC:
chromium-reviews, Michael Achenbach Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having {asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots:
mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng
linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng
linux_chromium_asan_rel_ng
Committed: https://crrev.com/83d8599fdab6538bc3e9cf6e8c9458214a7a8671
Cr-Commit-Position: refs/heads/master@{#439452}
Patch Set 1 #Patch Set 2 : Made the example paths different from the actual defaults #
Messages
Total messages: 24 (15 generated)
Description was changed from
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
==========
to
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots
==========
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots
==========
to
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots: mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng linux_chromium_asan_rel_ng
==========
Description was changed from
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots: mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng linux_chromium_asan_rel_ng
==========
to
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots:
mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng
linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng
linux_chromium_asan_rel_ng
==========
kjellander@chromium.org changed reviewers: + glider@chromium.org, jochen@chromium.org
glider: main review jochen: rubberstamp for build/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
glider@google.com changed reviewers: + glider@google.com
LGTM
On 2016/12/19 10:58:05, _com_google_glider wrote: > LGTM LGTM for realz
lgtm
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482146162742720,
"parent_rev": "600adeb559cfb62c20a8027410dbe27d460dba57", "commit_rev":
"84e9143850058cae9141a1ff535c852017dc6e83"}
Message was sent while issue was closed.
Description was changed from
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots:
mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng
linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng
linux_chromium_asan_rel_ng
==========
to
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots:
mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng
linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng
linux_chromium_asan_rel_ng
Review-Url: https://codereview.chromium.org/2580313002
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots:
mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng
linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng
linux_chromium_asan_rel_ng
Review-Url: https://codereview.chromium.org/2580313002
==========
to
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots:
mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng
linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng
linux_chromium_asan_rel_ng
Committed: https://crrev.com/83d8599fdab6538bc3e9cf6e8c9458214a7a8671
Cr-Commit-Position: refs/heads/master@{#439452}
==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/83d8599fdab6538bc3e9cf6e8c9458214a7a8671 Cr-Commit-Position: refs/heads/master@{#439452}
Message was sent while issue was closed.
Description was changed from
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots:
mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng
linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng
linux_chromium_asan_rel_ng
Committed: https://crrev.com/83d8599fdab6538bc3e9cf6e8c9458214a7a8671
Cr-Commit-Position: refs/heads/master@{#439452}
==========
to
==========
Make sanitizer suppressions and blacklists fully configurable.
This will make it possible to fully utilize the sanitizers in other
projects that may need to maintain their own suppressions and blacklists.
This change also removes the requirement on having
{asan,lsan,tsan}_suppressions_file
defined in //build_overrides/build.gni, simplifying the build configs.
BUG=webrtc:5006
TESTED=CQ dry run + additional sanitizer trybots:
mac_chromium_asan_rel_ng
linux_chromium_ubsan_rel_ng
linux_chromium_msan_rel_ng
linux_chromium_tsan_rel_ng
linux_chromium_asan_rel_ng
Committed: https://crrev.com/83d8599fdab6538bc3e9cf6e8c9458214a7a8671
Cr-Commit-Position: refs/heads/master@{#439452}
==========
Message was sent while issue was closed.
+dpranke FYI. I think this is a good pattern for how we should deal with these build_overrides to avoid breaking downstream. Until there's a new way that avoids it entirely of course.
Message was sent while issue was closed.
On 2016/12/19 16:19:57, kjellander_chromium wrote: > +dpranke FYI. I think this is a good pattern for how we should deal with these > build_overrides to avoid breaking downstream. Until there's a new way that > avoids it entirely of course. Someone is now working on what will hopefully be the better way; see https://codereview.chromium.org/2581193003/ . |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
