Make sanitizer suppressions and blacklists fully configurable.

build/config/sanitizers/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build_overrides/build.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/chromecast_build.gni")
 import("//build/config/clang/clang.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/toolchain/toolchain.gni")
@@ skipping 149 matching lines @@
   sources = [
     "//build/sanitizers/sanitizer_options.cc",
   ]
 
   # Don't compile this target with any sanitizer code. It can be called from
   # the sanitizer runtimes, so instrumenting these functions could cause
   # recursive calls into the runtime if there is an error.
   configs -= [ "//build/config/sanitizers:default_sanitizer_flags" ]
 
   if (is_asan) {
+    if (!defined(asan_suppressions_file)) {
+      asan_suppressions_file = "//build/sanitizers/asan_suppressions.cc"
+    }
     sources += [ asan_suppressions_file ]
   }
 
   if (is_lsan) {
+    if (!defined(lsan_suppressions_file)) {
+      lsan_suppressions_file = "//build/sanitizers/lsan_suppressions.cc"
+    }
     sources += [ lsan_suppressions_file ]
   }
 
   if (is_tsan) {
+    if (!defined(tsan_suppressions_file)) {
+      tsan_suppressions_file = "//build/sanitizers/tsan_suppressions.cc"
+    }
     sources += [ tsan_suppressions_file ]
   }
 }
 
 # Applies linker flags necessary when either :deps or :default_sanitizer_flags
 # are used.
 config("default_sanitizer_ldflags") {
   visibility = [
     ":default_sanitizer_flags",
     ":deps",
@@ skipping 112 matching lines @@
   cflags = []
   if (is_asan) {
     cflags += [ "-fsanitize=address" ]
     if (!asan_globals) {
       cflags += [
         "-mllvm",
         "-asan-globals=0",
       ]
     }
     if (is_win) {
-      cflags += [ "-fsanitize-blacklist=" +
-                  rebase_path("//tools/memory/asan/blacklist_win.txt",
-                              root_build_dir) ]
+      if (!defined(asan_win_blacklist_path)) {
+        asan_win_blacklist_path =
+            rebase_path("//tools/memory/asan/blacklist_win.txt", root_build_dir)
+      }
+      cflags += [ "-fsanitize-blacklist=$asan_win_blacklist_path" ]
     } else {
       # TODO(rnk): Remove this as discussed in http://crbug.com/427202.
-      cflags +=
-          [ "-fsanitize-blacklist=" +
-            rebase_path("//tools/memory/asan/blacklist.txt", root_build_dir) ]
+      if (!defined(asan_blacklist_path)) {
+        asan_blacklist_path =
+            rebase_path("//tools/memory/asan/blacklist.txt", root_build_dir)
+      }
+      cflags += [ "-fsanitize-blacklist=$asan_blacklist_path" ]
     }
   }
 }
 
 config("link_executable") {
   if (is_asan && is_win && !is_component_build) {
     if (target_cpu == "x64") {
       # Windows 64-bit. TODO(etienneb): Remove the assert when this is ready.
       assert(false, "win/asan does not work in 64-bit yet")
       libs = [ "clang_rt.asan-x86_64.lib" ]
@@ skipping 13 matching lines @@
     } else {
       assert(target_cpu == "x86", "WinASan unsupported architecture")
       libs = [ "clang_rt.asan_dll_thunk-i386.lib" ]
     }
   }
 }
 
 config("cfi_flags") {
   cflags = []
   if (is_cfi && !is_nacl) {
-    cfi_blacklist_path =
-        rebase_path("//tools/cfi/blacklist.txt", root_build_dir)
+    if (!defined(cfi_blacklist_path)) {
+      cfi_blacklist_path =
+          rebase_path("//tools/cfi/blacklist.txt", root_build_dir)
+    }
     cflags += [
       "-fsanitize=cfi-vcall",
       "-fsanitize-blacklist=$cfi_blacklist_path",
     ]
 
     if (use_cfi_cast) {
       cflags += [
         "-fsanitize=cfi-derived-cast",
         "-fsanitize=cfi-unrelated-cast",
       ]
@@ skipping 36 matching lines @@
 
 config("lsan_flags") {
   if (is_lsan) {
     cflags = [ "-fsanitize=leak" ]
   }
 }
 
 config("msan_flags") {
   if (is_msan) {
     assert(is_linux, "msan only supported on linux x86_64")
-    msan_blacklist_path =
-        rebase_path("//tools/msan/blacklist.txt", root_build_dir)
+    if (!defined(msan_blacklist_path)) {
+      msan_blacklist_path =
+          rebase_path("//tools/msan/blacklist.txt", root_build_dir)
+    }
     cflags = [
       "-fsanitize=memory",
       "-fsanitize-memory-track-origins=$msan_track_origins",
       "-fsanitize-blacklist=$msan_blacklist_path",
     ]
   }
 }
 
 config("tsan_flags") {
   if (is_tsan) {
     assert(is_linux, "tsan only supported on linux x86_64")
-    tsan_blacklist_path =
-        rebase_path("//tools/memory/tsan_v2/ignores.txt", root_build_dir)
+    if (!defined(tsan_blacklist_path)) {
+      tsan_blacklist_path =
+          rebase_path("//tools/memory/tsan_v2/ignores.txt", root_build_dir)
+    }
     cflags = [
       "-fsanitize=thread",
       "-fsanitize-blacklist=$tsan_blacklist_path",
     ]
   }
 }
 
 # UBSan is still in bring-up.  Chrome builds with is_ubsan=true, but if you
 # set is_ubsan=true is_ubsan_no_recover = true, then many tests are still
 # failing.
 config("ubsan_flags") {
   cflags = []
   if (is_ubsan) {
-    ubsan_blacklist_path =
-        rebase_path("//tools/ubsan/blacklist.txt", root_build_dir)
+    if (!defined(ubsan_blacklist_path)) {
+      ubsan_blacklist_path =
+          rebase_path("//tools/ubsan/blacklist.txt", root_build_dir)
+    }
     cflags += [
       # Yasm dies with an "Illegal instruction" error when bounds checking is
       # enabled. See http://crbug.com/489901
       # "-fsanitize=bounds",
       "-fsanitize=float-divide-by-zero",
       "-fsanitize=float-cast-overflow",
       "-fsanitize=integer-divide-by-zero",
       "-fsanitize=null",
       "-fsanitize=object-size",
       "-fsanitize=return",
@@ skipping 25 matching lines @@
 }
 
 config("ubsan_no_recover") {
   if (is_ubsan_no_recover) {
     cflags = [ "-fno-sanitize-recover=undefined" ]
   }
 }
 
 config("ubsan_security_flags") {
   if (is_ubsan_security) {
-    ubsan_security_blacklist_path =
-        rebase_path("//tools/ubsan/security_blacklist.txt", root_build_dir)
+    if (!defined(ubsan_security_blacklist_path)) {
+      ubsan_security_blacklist_path =
+          rebase_path("//tools/ubsan/security_blacklist.txt", root_build_dir)
+    }
     cflags = [
       "-fsanitize=signed-integer-overflow,shift,vptr,function,vla-bound",
       "-fsanitize-blacklist=$ubsan_security_blacklist_path",
     ]
   }
 }
 
 config("ubsan_null_flags") {
   if (is_ubsan_null) {
     cflags = [ "-fsanitize=null" ]
   }
 }
 
 config("ubsan_vptr_flags") {
   if (is_ubsan_vptr) {
-    ubsan_vptr_blacklist_path =
-        rebase_path("//tools/ubsan/vptr_blacklist.txt", root_build_dir)
+    if (!defined(ubsan_vptr_blacklist_path)) {
+      ubsan_vptr_blacklist_path =
+          rebase_path("//tools/ubsan/vptr_blacklist.txt", root_build_dir)
+    }
     cflags = [
       "-fsanitize=vptr",
       "-fsanitize-blacklist=$ubsan_vptr_blacklist_path",
     ]
   }
 }
 
 all_sanitizer_configs = [
   ":common_sanitizer_flags",
   ":coverage_flags",
@@ skipping 26 matching lines @@
 # This allows to selectively disable ubsan_vptr, when needed. In particular,
 # if some third_party code is required to be compiled without rtti, which
 # is a requirement for ubsan_vptr.
 config("default_sanitizer_flags_but_ubsan_vptr") {
   configs = all_sanitizer_configs - [ ":ubsan_vptr_flags" ]
 }
 
 config("default_sanitizer_flags_but_coverage") {
   configs = all_sanitizer_configs - [ ":coverage_flags" ]
 }