Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: content/shell/browser/shell_devtools_frontend.cc

Issue 2579923002: [DevTools] Call InnerDetach instead of NotifyDetached in DTAHI::HostClosed. (Closed)
Patch Set: no deps Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/browser/shell_devtools_frontend.h" 5 #include "content/shell/browser/shell_devtools_frontend.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/json/json_reader.h" 9 #include "base/json/json_reader.h"
10 #include "base/json/json_writer.h" 10 #include "base/json/json_writer.h"
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 366
367 void ShellDevToolsFrontend::SendMessageAck(int request_id, 367 void ShellDevToolsFrontend::SendMessageAck(int request_id,
368 const base::Value* arg) { 368 const base::Value* arg) {
369 base::FundamentalValue id_value(request_id); 369 base::FundamentalValue id_value(request_id);
370 CallClientFunction("DevToolsAPI.embedderMessageAck", 370 CallClientFunction("DevToolsAPI.embedderMessageAck",
371 &id_value, arg, nullptr); 371 &id_value, arg, nullptr);
372 } 372 }
373 373
374 void ShellDevToolsFrontend::AgentHostClosed( 374 void ShellDevToolsFrontend::AgentHostClosed(
375 DevToolsAgentHost* agent_host, bool replaced) { 375 DevToolsAgentHost* agent_host, bool replaced) {
376 agent_host_ = nullptr;
376 frontend_shell_->Close(); 377 frontend_shell_->Close();
377 } 378 }
378 379
379 } // namespace content 380 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698