Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2579913002: [ARM] Add NEON instructions for implementing SIMD. (Closed)

Created:
4 years ago by bbudge
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Add NEON instructions for implementing SIMD. - Adds vabs, vneg, vmul, vext, vzip, vrev instructions. - Adds Swizzle function to macro assembler. - Simplifies if-else logic in disassembler, simulator, for Neon special. - Some refactoring of Neon assembler, macro-assembler tests. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2579913002 Cr-Commit-Position: refs/heads/master@{#41781} Committed: https://chromium.googlesource.com/v8/v8/+/431223f34fafec07b7c42f6fa2fb832b82d86c94

Patch Set 1 #

Patch Set 2 : Implement Neon vmul. #

Patch Set 3 : Clean up. #

Total comments: 27

Patch Set 4 : Review comments. #

Patch Set 5 : Fix typos, make test code a little clearer. #

Total comments: 2

Patch Set 6 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1135 lines, -258 lines) Patch
M src/arm/assembler-arm.h View 1 2 3 2 chunks +17 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 2 3 4 chunks +140 lines, -1 line 0 comments Download
M src/arm/disasm-arm.cc View 1 2 3 4 chunks +115 lines, -55 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 3 1 chunk +58 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 2 3 4 5 10 chunks +410 lines, -122 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 2 3 4 13 chunks +252 lines, -80 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 2 3 3 chunks +30 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 2 3 1 chunk +111 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (22 generated)
bbudge
Another batch of NEON instructions. Fun!
4 years ago (2016-12-16 01:14:57 UTC) #10
Rodolph Perfetta (ARM)
https://codereview.chromium.org/2579913002/diff/40001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/2579913002/diff/40001/src/arm/assembler-arm.cc#newcode4081 src/arm/assembler-arm.cc:4081: int vd, d; DCHECK is_float => size is Neon32 ...
4 years ago (2016-12-16 20:50:12 UTC) #11
bbudge
Thanks Rodolph. I think I got everything. PTAL https://codereview.chromium.org/2579913002/diff/40001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/2579913002/diff/40001/src/arm/assembler-arm.cc#newcode4081 src/arm/assembler-arm.cc:4081: int ...
4 years ago (2016-12-17 01:08:32 UTC) #14
Rodolph Perfetta (ARM)
lgtm https://codereview.chromium.org/2579913002/diff/80001/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): https://codereview.chromium.org/2579913002/diff/80001/src/arm/simulator-arm.cc#newcode4428 src/arm/simulator-arm.cc:4428: if (s[i] < 0) s[i] = std::abs(s[i]); very ...
4 years ago (2016-12-17 13:44:32 UTC) #17
bbudge
https://codereview.chromium.org/2579913002/diff/80001/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): https://codereview.chromium.org/2579913002/diff/80001/src/arm/simulator-arm.cc#newcode4428 src/arm/simulator-arm.cc:4428: if (s[i] < 0) s[i] = std::abs(s[i]); On 2016/12/17 ...
4 years ago (2016-12-17 21:54:36 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579913002/100001
4 years ago (2016-12-17 21:54:49 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-17 21:56:34 UTC) #29
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/431223f34fafec07b7c42f6fa2fb832b82d...

Powered by Google App Engine
This is Rietveld 408576698