Using ShellObserver instead of creating MaximizeModeController::Observer

Using ShellObserver instead of creating MaximizeModeController::Observer

Changes:
MaximizeModeController's EnableMaximizeModeWindowManager (which is
called in EnterMaximizeMode and LeaveMaximizeMode) will fire events for
ShellObserver. Thus we don't need to create duplicate observers in
MaximizeModeController.

BUG=633304
TEST=automated tests

Committed: https://crrev.com/4d0923a66bb239acfec65cdff715f66c4171bb02
Cr-Commit-Position: refs/heads/master@{#439226}

[Qiang(Joe) Xu, 2016-12-16 02:37:13]

Description was changed from

==========
Using ShellObserver instead of creating MaximizeModeController::Observer

Changes:
MaximizeModeController's EnableMaximizeModeWindowManager (which is
called in EnterMaximizeMode and LeaveMaximizeMode) will fire events for
ShellObserver. Thus we don't need to create duplicate observers in
MaximizeModeController.

BUG=633304
TEST=automated tests
==========

to

==========
Using ShellObserver instead of creating MaximizeModeController::Observer

Changes:
MaximizeModeController's EnableMaximizeModeWindowManager (which is
called in EnterMaximizeMode and LeaveMaximizeMode) will fire events for
ShellObserver. Thus we don't need to create duplicate observers in
MaximizeModeController.

BUG=633304
TEST=automated tests
==========

[Qiang(Joe) Xu, 2016-12-16 02:37:14]

warx@chromium.org changed reviewers:
+ derat@chromium.org

[Qiang(Joe) Xu, 2016-12-16 02:38:21]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 02:39:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2016-12-16 03:36:01]

Hi Daniel, please take a look for this update, thanks!

[commit-bot: I haz the power, 2016-12-16 04:52:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 04:52:07]

Dry run: This issue passed the CQ dry run.

[Daniel Erat, 2016-12-16 16:07:05]

lgtm

thanks for simplifying this code!

[Qiang(Joe) Xu, 2016-12-16 23:06:47]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2016-12-16 23:07:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 23:12:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481929607178460, "parent_rev":
"0655523eca38f6b94279a0b6fb4d34a4f5ee3dcd", "commit_rev":
"e0c5e1c9e8146b1bbcbd711b5e1c236bd97ca9f1"}

[commit-bot: I haz the power, 2016-12-16 23:13:21]

Description was changed from

==========
Using ShellObserver instead of creating MaximizeModeController::Observer

Changes:
MaximizeModeController's EnableMaximizeModeWindowManager (which is
called in EnterMaximizeMode and LeaveMaximizeMode) will fire events for
ShellObserver. Thus we don't need to create duplicate observers in
MaximizeModeController.

BUG=633304
TEST=automated tests
==========

to

==========
Using ShellObserver instead of creating MaximizeModeController::Observer

Changes:
MaximizeModeController's EnableMaximizeModeWindowManager (which is
called in EnterMaximizeMode and LeaveMaximizeMode) will fire events for
ShellObserver. Thus we don't need to create duplicate observers in
MaximizeModeController.

BUG=633304
TEST=automated tests

Review-Url: https://codereview.chromium.org/2579703003
==========

[commit-bot: I haz the power, 2016-12-16 23:13:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 23:16:10]

Description was changed from

==========
Using ShellObserver instead of creating MaximizeModeController::Observer

Changes:
MaximizeModeController's EnableMaximizeModeWindowManager (which is
called in EnterMaximizeMode and LeaveMaximizeMode) will fire events for
ShellObserver. Thus we don't need to create duplicate observers in
MaximizeModeController.

BUG=633304
TEST=automated tests

Review-Url: https://codereview.chromium.org/2579703003
==========

to

==========
Using ShellObserver instead of creating MaximizeModeController::Observer

Changes:
MaximizeModeController's EnableMaximizeModeWindowManager (which is
called in EnterMaximizeMode and LeaveMaximizeMode) will fire events for
ShellObserver. Thus we don't need to create duplicate observers in
MaximizeModeController.

BUG=633304
TEST=automated tests

Committed: https://crrev.com/4d0923a66bb239acfec65cdff715f66c4171bb02
Cr-Commit-Position: refs/heads/master@{#439226}
==========

[commit-bot: I haz the power, 2016-12-16 23:16:11]

Patchset 1 (id:??) landed as
https://crrev.com/4d0923a66bb239acfec65cdff715f66c4171bb02
Cr-Commit-Position: refs/heads/master@{#439226}