Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2666)

Unified Diff: ash/system/chromeos/power/tablet_power_button_controller.cc

Issue 2579703003: Using ShellObserver instead of creating MaximizeModeController::Observer (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/chromeos/power/tablet_power_button_controller.cc
diff --git a/ash/system/chromeos/power/tablet_power_button_controller.cc b/ash/system/chromeos/power/tablet_power_button_controller.cc
index 6b02fecf93f3fd337db433b9ddfed9c7580afa88..4600b46b0538b2281b42cdbe0a24bc234e3cf639 100644
--- a/ash/system/chromeos/power/tablet_power_button_controller.cc
+++ b/ash/system/chromeos/power/tablet_power_button_controller.cc
@@ -7,6 +7,7 @@
#include "ash/common/accessibility_delegate.h"
#include "ash/common/session/session_state_delegate.h"
#include "ash/common/shell_delegate.h"
+#include "ash/common/wm/maximize_mode/maximize_mode_controller.h"
#include "ash/common/wm_shell.h"
#include "ash/shell.h"
#include "ash/wm/lock_state_controller.h"
@@ -72,8 +73,7 @@ TabletPowerButtonController::TabletPowerButtonController(
weak_ptr_factory_(this) {
chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->AddObserver(
this);
- if (WmShell::Get()->maximize_mode_controller())
- WmShell::Get()->maximize_mode_controller()->AddObserver(this);
+ WmShell::Get()->AddShellObserver(this);
ui::InputDeviceManager::GetInstance()->AddObserver(this);
Shell::GetInstance()->PrependPreTargetHandler(this);
@@ -83,8 +83,7 @@ TabletPowerButtonController::TabletPowerButtonController(
TabletPowerButtonController::~TabletPowerButtonController() {
Shell::GetInstance()->RemovePreTargetHandler(this);
ui::InputDeviceManager::GetInstance()->RemoveObserver(this);
- if (WmShell::Get()->maximize_mode_controller())
- WmShell::Get()->maximize_mode_controller()->RemoveObserver(this);
+ WmShell::Get()->RemoveShellObserver(this);
chromeos::DBusThreadManager::Get()->GetPowerManagerClient()->RemoveObserver(
this);
}
@@ -142,13 +141,13 @@ void TabletPowerButtonController::SuspendDone(
last_resume_time_ = tick_clock_->NowTicks();
}
-void TabletPowerButtonController::OnEnterMaximizeMode() {
+void TabletPowerButtonController::OnMaximizeModeStarted() {
shutdown_timer_.Stop();
if (controller_->CanCancelShutdownAnimation())
controller_->CancelShutdownAnimation();
}
-void TabletPowerButtonController::OnLeaveMaximizeMode() {
+void TabletPowerButtonController::OnMaximizeModeEnded() {
shutdown_timer_.Stop();
if (controller_->CanCancelShutdownAnimation())
controller_->CancelShutdownAnimation();

Powered by Google App Engine
This is Rietveld 408576698