Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2579513005:
Expose FontFaceSetLoadEvent and add a constructor for it (Closed)
|
Created:
4 years ago by lunalu1 Modified:
3 years, 11 months ago CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, blink-reviews-css, eae+blinkwatch, blink-reviews-events_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionExpose FontFaceSetLoadEvent and add a constructor for it
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/AlZEmkeiKg8
BUG=673664
Review-Url: https://codereview.chromium.org/2579513005
Cr-Commit-Position: refs/heads/master@{#443950}
Committed: https://chromium.googlesource.com/chromium/src/+/84f416819a18138cdf94d39f7f0e313fb310a94a
Patch Set 1 #Patch Set 2 : Fix compile err #
Total comments: 2
Patch Set 3 : Add FontFaceSetLoadEvent to global-interface-listing #Patch Set 4 : Make fontfaces FrozenArray [SameObject] #
Total comments: 7
Patch Set 5 : Codereview update #Patch Set 6 : Update rebase #
Total comments: 3
Patch Set 7 : Remove 'SaveSameObject' cause it is not needed for performance #Patch Set 8 : Update test expects #Patch Set 9 : Update rebase #Messages
Total messages: 102 (68 generated)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lunalu@chromium.org changed reviewers: + foolip@chromium.org
https://codereview.chromium.org/2579513005/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/css/fontfacesetloadevent-constructor.html (right): https://codereview.chromium.org/2579513005/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/css/fontfacesetloadevent-constructor.html:7: assert_equals(new FontFaceSetLoadEvent('type').fontfaces, undefined); Does this not fail? I would expect assert_array_equals(new FontFaceSetLoadEvent('type').fontfaces, []); https://codereview.chromium.org/2579513005/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/css/fontfacesetloadevent-constructor.html:12: assert_equals(new FontFaceSetLoadEvent('type', { fontfaces: ff }).fontfaces, I filed https://github.com/w3c/csswg-drafts/issues/810 because it would change this test. First assert_array_equals that the arrays have the same members, and the assert_not_equals that they aren't actually the very same array. We probably fail the second assert now.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Expose FontFaceSetLoadEvent and add a constructor for it BUG=673664 ========== to ========== Expose FontFaceSetLoadEvent and add a constructor for it Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/AlZEmkeiKg8 BUG=673664 ==========
Done. Thanks
lgtm % nits and doubts. https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/css/fontfacesetloadevent-constructor.html (right): https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/css/fontfacesetloadevent-constructor.html:10: assert_not_equals(e.fontfaces, []); This assert looks a bit paranoid, it would be a thrilling bug if e.fontfaces could return the same value as an array literal. If you have a ff = [] variable similar to the following test, it'd make sense though. https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt (right): https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:1391: interface FontFaceSetLoadEvent : Event Likely copypasta https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h (right): https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:33: X(SameObject, FontFaceSetLoadEventFontfaces) \ I didn't know we had to do this for SaveSameObject. Can you blame and ask whoever wrote the surrounding code if it's expected that this will grow by a lot and if that's a problem?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Done. Thanks https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/css/fontfacesetloadevent-constructor.html (right): https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/css/fontfacesetloadevent-constructor.html:10: assert_not_equals(e.fontfaces, []); On 2016/12/16 14:46:36, foolip wrote: > This assert looks a bit paranoid, it would be a thrilling bug if e.fontfaces > could return the same value as an array literal. If you have a ff = [] variable > similar to the following test, it'd make sense though. Done. https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt (right): https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt:1391: interface FontFaceSetLoadEvent : Event On 2016/12/16 14:46:36, foolip wrote: > Likely copypasta Done. https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h (right): https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:33: X(SameObject, FontFaceSetLoadEventFontfaces) \ On 2016/12/16 14:46:36, foolip wrote: > I didn't know we had to do this for SaveSameObject. Can you blame and ask > whoever wrote the surrounding code if it's expected that this will grow by a lot > and if that's a problem? If we don't do that, it simply won't compile.
https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h (right): https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:33: X(SameObject, FontFaceSetLoadEventFontfaces) \ On 2016/12/16 15:44:56, loonybear wrote: > On 2016/12/16 14:46:36, foolip wrote: > > I didn't know we had to do this for SaveSameObject. Can you blame and ask > > whoever wrote the surrounding code if it's expected that this will grow by a > lot > > and if that's a problem? > > If we don't do that, it simply won't compile. Right, I'm just wondering if there's any cost to introducing more of these, in startup time or anything else. If the list can grow endlessly without problem, then all is well.
On 2016/12/16 16:13:07, foolip wrote: > https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Sour... > File third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h (right): > > https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Sour... > third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:33: X(SameObject, > FontFaceSetLoadEventFontfaces) \ > On 2016/12/16 15:44:56, loonybear wrote: > > On 2016/12/16 14:46:36, foolip wrote: > > > I didn't know we had to do this for SaveSameObject. Can you blame and ask > > > whoever wrote the surrounding code if it's expected that this will grow by a > > lot > > > and if that's a problem? > > > > If we don't do that, it simply won't compile. > > Right, I'm just wondering if there's any cost to introducing more of these, in > startup time or anything else. If the list can grow endlessly without problem, > then all is well. Ohhh good points. Sorry I didn't think of that. Should we get some expert to review this CL then? I need owners approval for V8PrivateProperty.h anyways I suppose?
On 2016/12/16 16:19:39, loonybear wrote: > On 2016/12/16 16:13:07, foolip wrote: > > > https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Sour... > > File third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h (right): > > > > > https://codereview.chromium.org/2579513005/diff/60001/third_party/WebKit/Sour... > > third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h:33: > X(SameObject, > > FontFaceSetLoadEventFontfaces) \ > > On 2016/12/16 15:44:56, loonybear wrote: > > > On 2016/12/16 14:46:36, foolip wrote: > > > > I didn't know we had to do this for SaveSameObject. Can you blame and ask > > > > whoever wrote the surrounding code if it's expected that this will grow by > a > > > lot > > > > and if that's a problem? > > > > > > If we don't do that, it simply won't compile. > > > > Right, I'm just wondering if there's any cost to introducing more of these, in > > startup time or anything else. If the list can grow endlessly without problem, > > then all is well. > > Ohhh good points. Sorry I didn't think of that. > Should we get some expert to review this CL then? I need owners approval for > V8PrivateProperty.h anyways I suppose? OWNERS-wise my LGTM is enough, but I would like a second opinion anyway :)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by lunalu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2579513005/#ps100001 (title: "Bug fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Patchset #6 (id:100001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lunalu@chromium.org changed reviewers: + haraken@chromium.org
Hi haraken@, could you please confirm that the change in V8PrivateProperty.h is safe? Thanks
Hi haraken@, could you please confirm that the change in V8PrivateProperty.h is safe? Thanks
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
LGTM with a comment https://codereview.chromium.org/2579513005/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/css/FontFaceSetLoadEvent.idl (right): https://codereview.chromium.org/2579513005/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/core/css/FontFaceSetLoadEvent.idl:38: [SameObject, SaveSameObject] readonly attribute FrozenArray<FontFace> fontfaces; [SaveSameObject] is a hack to optimize performance. Unless this is really performance-sensitive, you can drop the IDL extended attribute. Then you can also drop the change in V8PrivateProperty.
The CQ bit was checked by lunalu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org, haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2579513005/#ps140001 (title: "CCode review update")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by lunalu@chromium.org to run a CQ dry run
Patchset #7 (id:140001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2579513005/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/css/FontFaceSetLoadEvent.idl (right): https://codereview.chromium.org/2579513005/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/core/css/FontFaceSetLoadEvent.idl:38: [SameObject, SaveSameObject] readonly attribute FrozenArray<FontFace> fontfaces; On 2016/12/21 00:13:49, haraken wrote: > > [SaveSameObject] is a hack to optimize performance. Unless this is really > performance-sensitive, you can drop the IDL extended attribute. Then you can > also drop the change in V8PrivateProperty. Done.
The CQ bit was checked by lunalu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2579513005/#ps160001 (title: "Update rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by lunalu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2579513005/#ps180001 (title: "Update rebase")
Patchset #7 (id:160001) has been deleted
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #7 (id:180001) has been deleted
The CQ bit was checked by lunalu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2579513005/#ps200001 (title: "Update rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/2579513005/diff/120001/third_party/WebKit/Sou... File third_party/WebKit/Source/core/css/FontFaceSetLoadEvent.idl (right): https://codereview.chromium.org/2579513005/diff/120001/third_party/WebKit/Sou... third_party/WebKit/Source/core/css/FontFaceSetLoadEvent.idl:38: [SameObject, SaveSameObject] readonly attribute FrozenArray<FontFace> fontfaces; On 2016/12/21 18:51:32, loonybear (OOO until Jan 6) wrote: > On 2016/12/21 00:13:49, haraken wrote: > > > > [SaveSameObject] is a hack to optimize performance. Unless this is really > > performance-sensitive, you can drop the IDL extended attribute. Then you can > > also drop the change in V8PrivateProperty. > > Done. Is it not needed to get the event.fontfaces===event.fontfaces behavior right?
Patchset #7 (id:200001) has been deleted
The CQ bit was checked by lunalu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2579513005/#ps220001 (title: "Remove 'SaveSameObject' cause it is not needed for performance")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lunalu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lunalu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by lunalu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2579513005/#ps240001 (title: "Update test expects")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt:
While running git apply --index -p1;
error: patch failed:
third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt:10
error:
third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt:
patch does not apply
Patch:
third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
Index:
third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
diff --git
a/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
b/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
index
2712ad35c922eaaf6ecf5de8c484ee9ccaf7366b..f2517de771333c35206df9e0b649b22151f9b9d9
100644
---
a/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
+++
b/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
@@ -10,7 +10,7 @@ FAIL [[GetOwnProperty]] - Property descriptors for
cross-origin properties shoul
FAIL [[Delete]] Should throw on cross-origin objects assert_throws: Can't
delete cross-origin indexed property function "function () { delete C[0]; }" did
not throw
FAIL [[DefineOwnProperty]] Should throw for cross-origin objects assert_throws:
Can't define cross-origin value property length function "function () {
Object.defineProperty(obj, prop, valueDesc); }" did not throw
FAIL [[Enumerate]] should return an empty iterator assert_unreached: Shouldn't
have been able to enumerate stop on cross-origin Window Reached unreachable code
-FAIL [[OwnPropertyKeys]] should return all properties from cross-origin objects
assert_array_equals: Object.getOwnPropertyNames() gives the right answer for
cross-origin Window lengths differ, expected 874 got 13
+FAIL [[OwnPropertyKeys]] should return all properties from cross-origin objects
assert_array_equals: Object.getOwnPropertyNames() gives the right answer for
cross-origin Window lengths differ, expected 875 got 13
PASS A and B jointly observe the same identity for cross-origin Window and
Location
PASS Cross-origin functions get local Function.prototype
FAIL Cross-origin Window accessors get local Function.prototype Cannot read
property 'name' of undefined
The CQ bit was checked by lunalu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for
third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt:
While running git apply --index -p1;
error: patch failed:
third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt:10
error:
third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt:
patch does not apply
Patch:
third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
Index:
third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
diff --git
a/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
b/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
index
2712ad35c922eaaf6ecf5de8c484ee9ccaf7366b..f2517de771333c35206df9e0b649b22151f9b9d9
100644
---
a/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
+++
b/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
@@ -10,7 +10,7 @@ FAIL [[GetOwnProperty]] - Property descriptors for
cross-origin properties shoul
FAIL [[Delete]] Should throw on cross-origin objects assert_throws: Can't
delete cross-origin indexed property function "function () { delete C[0]; }" did
not throw
FAIL [[DefineOwnProperty]] Should throw for cross-origin objects assert_throws:
Can't define cross-origin value property length function "function () {
Object.defineProperty(obj, prop, valueDesc); }" did not throw
FAIL [[Enumerate]] should return an empty iterator assert_unreached: Shouldn't
have been able to enumerate stop on cross-origin Window Reached unreachable code
-FAIL [[OwnPropertyKeys]] should return all properties from cross-origin objects
assert_array_equals: Object.getOwnPropertyNames() gives the right answer for
cross-origin Window lengths differ, expected 874 got 13
+FAIL [[OwnPropertyKeys]] should return all properties from cross-origin objects
assert_array_equals: Object.getOwnPropertyNames() gives the right answer for
cross-origin Window lengths differ, expected 875 got 13
PASS A and B jointly observe the same identity for cross-origin Window and
Location
PASS Cross-origin functions get local Function.prototype
FAIL Cross-origin Window accessors get local Function.prototype Cannot read
property 'name' of undefined
The CQ bit was checked by lunalu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2579513005/#ps260001 (title: "Update rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 260001, "attempt_start_ts": 1484596783488230,
"parent_rev": "4a9064a99588486772c9c2ec88e84e2a4f444f65", "commit_rev":
"84f416819a18138cdf94d39f7f0e313fb310a94a"}
Message was sent while issue was closed.
Description was changed from ========== Expose FontFaceSetLoadEvent and add a constructor for it Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/AlZEmkeiKg8 BUG=673664 ========== to ========== Expose FontFaceSetLoadEvent and add a constructor for it Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/AlZEmkeiKg8 BUG=673664 Review-Url: https://codereview.chromium.org/2579513005 Cr-Commit-Position: refs/heads/master@{#443950} Committed: https://chromium.googlesource.com/chromium/src/+/84f416819a18138cdf94d39f7f0e... ==========
Message was sent while issue was closed.
Committed patchset #9 (id:260001) as https://chromium.googlesource.com/chromium/src/+/84f416819a18138cdf94d39f7f0e... |
