third_party/WebKit/LayoutTests/fast/css/fontfacesetloadevent-constructor.html - Issue 2579513005: Expose FontFaceSetLoadEvent and add a constructor for it

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css/fontfacesetloadevent-constructor.html

Issue 2579513005: Expose FontFaceSetLoadEvent and add a constructor for it (Closed)

Patch Set: Make fontfaces FrozenArray [SameObject] Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>FontFaceSetLoadEvent Constructor</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6 test(function() {

	7 var e = new FontFaceSetLoadEvent('type');

	8 assert_array_equals(e.fontfaces, []);

	9 assert_equals(e.fontfaces, e.fontfaces);

	10 assert_not_equals(e.fontfaces, []);
	foolip 2016/12/16 14:46:36 This assert looks a bit paranoid, it would be a th This assert looks a bit paranoid, it would be a thrilling bug if e.fontfaces could return the same value as an array literal. If you have a ff = [] variable similar to the following test, it'd make sense though. lunalu1 2016/12/16 15:44:56 Done. Show quoted text On 2016/12/16 14:46:36, foolip wrote: > This assert looks a bit paranoid, it would be a thrilling bug if e.fontfaces > could return the same value as an array literal. If you have a ff = [] variable > similar to the following test, it'd make sense though. Done.
	11 }, 'Test FontFaceSetLoadEvent constructor without FontFaceSetLoadEventInit dic tionary');

	12

	13 test(function() {

	14 var ff = [ new FontFace('family', 'src') ];

	15 var e = new FontFaceSetLoadEvent('type', { fontfaces: ff });

	16 assert_array_equals(e.fontfaces, ff);

	17 assert_equals(e.fontfaces, e.fontfaces);

	18 assert_not_equals(e.fontfaces, ff);

	19 }, 'Test FontFaceSetLoadEvent constructor with FontFaceSetLoadEventInit dictio nary');

	20 </script>

OLD	NEW