Preparsing inner funcs: declare arguments for preparsed scopes

Preparsing inner funcs: declare arguments for preparsed scopes

This makes maybe_assigned correct (instead of being overly pessimistic
in the following case):

function f() { function g() { arguments; }; }

(Tests upcoming as part of https://codereview.chromium.org/2580833005 )

BUG=v8:5501, v8:5678
R=verwaest@chromium.org, neis@chromium.org

Review-Url: https://codereview.chromium.org/2579303002
Cr-Commit-Position: refs/heads/master@{#41787}
Committed: https://chromium.googlesource.com/v8/v8/+/b695c38842a05808106d3246f0c034bb0d2ebbcc

[marja, 2016-12-16 13:15:42]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 13:15:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-12-16 13:20:15]

Description was changed from

==========
Preparsing inner functions:

This makes maybe_assigned correct (instead of being overly pessimistic
in the following case):

function f() { function g() { arguments; }; }

(Tests upcoming as part of https://codereview.chromium.org/2580833005 )

BUG=v8:5501, v8:5678
R=verwaest@chromium.org, neis@chromium.org
==========

to

==========
Preparsing inner funcs: declare arguments for preparsed scopes

This makes maybe_assigned correct (instead of being overly pessimistic
in the following case):

function f() { function g() { arguments; }; }

(Tests upcoming as part of https://codereview.chromium.org/2580833005 )

BUG=v8:5501, v8:5678
R=verwaest@chromium.org, neis@chromium.org
==========

[marja, 2016-12-16 13:22:27]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 13:22:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-12-16 13:23:07]

ptal

[commit-bot: I haz the power, 2016-12-16 13:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 13:57:45]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-12-16 14:23:42]

lgtm.

We should do the same for all of the DeclareDefaultFunctionVariables. Mh. Is
"this" forced context allocated currently? :)

[marja, 2016-12-19 09:21:59]

added "this"

Not sure if preparser needs new_target; afaics not atm.

[marja, 2016-12-19 09:22:03]

The CQ bit was checked by marja@chromium.org

[marja, 2016-12-19 09:22:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2579303002/#ps40001
(title: "added this")

[commit-bot: I haz the power, 2016-12-19 09:22:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 09:47:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482139323372510,
"parent_rev": "f63f64ca1f9300c857c16041b3eb769a52432bbe", "commit_rev":
"b695c38842a05808106d3246f0c034bb0d2ebbcc"}

[commit-bot: I haz the power, 2016-12-19 09:47:10]

Description was changed from

==========
Preparsing inner funcs: declare arguments for preparsed scopes

This makes maybe_assigned correct (instead of being overly pessimistic
in the following case):

function f() { function g() { arguments; }; }

(Tests upcoming as part of https://codereview.chromium.org/2580833005 )

BUG=v8:5501, v8:5678
R=verwaest@chromium.org, neis@chromium.org
==========

to

==========
Preparsing inner funcs: declare arguments for preparsed scopes

This makes maybe_assigned correct (instead of being overly pessimistic
in the following case):

function f() { function g() { arguments; }; }

(Tests upcoming as part of https://codereview.chromium.org/2580833005 )

BUG=v8:5501, v8:5678
R=verwaest@chromium.org, neis@chromium.org

Review-Url: https://codereview.chromium.org/2579303002
Cr-Commit-Position: refs/heads/master@{#41787}
Committed:
https://chromium.googlesource.com/v8/v8/+/b695c38842a05808106d3246f0c034bb0d2...
==========

[commit-bot: I haz the power, 2016-12-19 09:47:11]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b695c38842a05808106d3246f0c034bb0d2...