Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2580833005: [test] Add more maybe-assigned tests for parameters. (Closed)

Created:
4 years ago by neis
Modified:
3 years, 11 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com, adamk
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Add more maybe-assigned tests for parameters. R=marja@chromium.org BUG= Review-Url: https://codereview.chromium.org/2580833005 Cr-Commit-Position: refs/heads/master@{#42006} Committed: https://chromium.googlesource.com/v8/v8/+/c5d75a381ff5fad9d01f58c0cef96603ca07ac70

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove precision flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M test/cctest/test-parsing.cc View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
neis
4 years ago (2016-12-16 10:12:01 UTC) #1
neis
https://codereview.chromium.org/2580833005/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/2580833005/diff/1/test/cctest/test-parsing.cc#newcode3459 test/cctest/test-parsing.cc:3459: "function f(arg) {g(arg); g(function() {arguments[0] = 42}); g(arg)}"}, This ...
4 years ago (2016-12-16 10:12:54 UTC) #2
neis
PTAL.
3 years, 11 months ago (2017-01-02 10:40:02 UTC) #3
marja
lgtm
3 years, 11 months ago (2017-01-02 10:51:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580833005/20001
3 years, 11 months ago (2017-01-02 10:59:38 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 11:25:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c5d75a381ff5fad9d01f58c0cef96603ca0...

Powered by Google App Engine
This is Rietveld 408576698