[EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3)

[EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3)

This is the last sub-patch (3/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

Instead of adding |EditCommandSource| to constructor, this CL:
1. Pass source to |CompositeEditCommand::apply(EditCommandSource)|
2. Pass source to various static methods of |TypingCommand|

We don't have to store command source as attribute because we only need it to fire
'beforeinput' in the above locations.
This approach also helped avoiding modifying all the |CompositeEditCommand|
constructors.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing

BUG=673789
Committed: https://crrev.com/acce62cb77947bf2f14d6c7ac74219d515a94ffb
Cr-Commit-Position: refs/heads/master@{#439130}

[chongz, 2016-12-16 04:27:41]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 04:28:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2016-12-16 04:40:12]

Description was changed from

==========
Pass command source to CompositEditCommand and TypingCommand

BUG=673789
==========

to

==========
[EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand|
(3/3)

This is the last sub-patch (3/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

Instead of adding |EditCommandSource| to constructor, this CL:
1. Pass source to |CompositeEditCommand::apply(EditCommandSource)|
2. Pass source to various static methods of |TypingCommand|

We don't have to store command source as attribute because we only need it to
fire
'beforeinput' in the above locations.
This approach also helped avoiding modifying all the |CompositeEditCommand| 
constructors.

This CL shouldn't have any behavior change.

BUG=673789
==========

[commit-bot: I haz the power, 2016-12-16 04:49:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 04:49:05]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[chongz, 2016-12-16 04:56:45]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 04:57:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 05:07:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 05:07:34]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[chongz, 2016-12-16 05:25:45]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[chongz, 2016-12-16 05:26:05]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-12-16 05:26:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2016-12-16 05:55:13]

Description was changed from

==========
[EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand|
(3/3)

This is the last sub-patch (3/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

Instead of adding |EditCommandSource| to constructor, this CL:
1. Pass source to |CompositeEditCommand::apply(EditCommandSource)|
2. Pass source to various static methods of |TypingCommand|

We don't have to store command source as attribute because we only need it to
fire
'beforeinput' in the above locations.
This approach also helped avoiding modifying all the |CompositeEditCommand| 
constructors.

This CL shouldn't have any behavior change.

BUG=673789
==========

to

==========
[EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand|
(3/3)

This is the last sub-patch (3/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

Instead of adding |EditCommandSource| to constructor, this CL:
1. Pass source to |CompositeEditCommand::apply(EditCommandSource)|
2. Pass source to various static methods of |TypingCommand|

We don't have to store command source as attribute because we only need it to
fire
'beforeinput' in the above locations.
This approach also helped avoiding modifying all the |CompositeEditCommand| 
constructors.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=673789
==========

[chongz, 2016-12-16 06:00:57]

chongz@chromium.org changed reviewers:
+ xiaochengh@chromium.org

[chongz, 2016-12-16 06:00:57]

xiaochengh@ PTAL at this last patch for passing command source, thanks!

To help reviewing I've also drafted a simple doc describing future plans, hope
that helps:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

[Xiaocheng, 2016-12-16 06:54:15]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2016-12-16 06:54:15]

Neat. lgtm.

+tkent

[tkent, 2016-12-16 07:57:45]

lgtm

[commit-bot: I haz the power, 2016-12-16 08:21:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 08:21:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chongz, 2016-12-16 17:02:41]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2016-12-16 17:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 17:11:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481907761486800,
"parent_rev": "45f88c7a8f04ea955fb802e2d0c560b05f523dde", "commit_rev":
"4c9b617de9c14ce2c2a3f775df851f1c5e17ec71"}

[commit-bot: I haz the power, 2016-12-16 17:12:10]

Description was changed from

==========
[EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand|
(3/3)

This is the last sub-patch (3/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

Instead of adding |EditCommandSource| to constructor, this CL:
1. Pass source to |CompositeEditCommand::apply(EditCommandSource)|
2. Pass source to various static methods of |TypingCommand|

We don't have to store command source as attribute because we only need it to
fire
'beforeinput' in the above locations.
This approach also helped avoiding modifying all the |CompositeEditCommand| 
constructors.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=673789
==========

to

==========
[EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand|
(3/3)

This is the last sub-patch (3/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

Instead of adding |EditCommandSource| to constructor, this CL:
1. Pass source to |CompositeEditCommand::apply(EditCommandSource)|
2. Pass source to various static methods of |TypingCommand|

We don't have to store command source as attribute because we only need it to
fire
'beforeinput' in the above locations.
This approach also helped avoiding modifying all the |CompositeEditCommand| 
constructors.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=673789

Review-Url: https://codereview.chromium.org/2579253002
==========

[commit-bot: I haz the power, 2016-12-16 17:12:11]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-12-16 17:15:51]

Description was changed from

==========
[EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand|
(3/3)

This is the last sub-patch (3/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

Instead of adding |EditCommandSource| to constructor, this CL:
1. Pass source to |CompositeEditCommand::apply(EditCommandSource)|
2. Pass source to various static methods of |TypingCommand|

We don't have to store command source as attribute because we only need it to
fire
'beforeinput' in the above locations.
This approach also helped avoiding modifying all the |CompositeEditCommand| 
constructors.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=673789

Review-Url: https://codereview.chromium.org/2579253002
==========

to

==========
[EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand|
(3/3)

This is the last sub-patch (3/3) of supporting |EditCommandSource| in
|CompositeEditCommand| (https://crrev.com/2574793002).

Instead of adding |EditCommandSource| to constructor, this CL:
1. Pass source to |CompositeEditCommand::apply(EditCommandSource)|
2. Pass source to various static methods of |TypingCommand|

We don't have to store command source as attribute because we only need it to
fire
'beforeinput' in the above locations.
This approach also helped avoiding modifying all the |CompositeEditCommand|
constructors.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=673789

Committed: https://crrev.com/acce62cb77947bf2f14d6c7ac74219d515a94ffb
Cr-Commit-Position: refs/heads/master@{#439130}
==========

[commit-bot: I haz the power, 2016-12-16 17:15:52]

Patchset 1 (id:??) landed as
https://crrev.com/acce62cb77947bf2f14d6c7ac74219d515a94ffb
Cr-Commit-Position: refs/heads/master@{#439130}

[chongz, 2017-01-16 21:11:52]

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2636043002/ by chongz@chromium.org.

The reason for reverting is: Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789..