third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp - Issue 2579253002: [EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

Issue 2579253002: [EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3) (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

index c7792716460e99c1df5e1960c61fa3bcb5800c86..bea2af380f1e7e4581027b3db3d25934c613dbca 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp

@@ -42,7 +42,7 @@ TEST_F(InsertListCommandTest, ShouldCleanlyRemoveSpuriousTextNode) {

InsertListCommand* command =

InsertListCommand::create(document(), InsertListCommand::OrderedList);

// This should not DCHECK.

- EXPECT_TRUE(command->apply())

+ EXPECT_TRUE(command->apply(EditCommandSource::kMenuOrKeyBinding))

<< "The insert ordered list command should have succeeded";

EXPECT_EQ("<ol><li>d</li></ol>", document().body()->innerHTML());

}