Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2578943002: [Bindings] Refactoring of binding code around runtime enabled features (Closed)

Created:
4 years ago by peria
Modified:
4 years ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring of binding code around runtime enabled features It didn't make sense to use 'runtime_enabled_function_name' to group runtime enabled features. Plus, 'runtime_feature_name' was also used in few places. It was so confusing. So this CL unify them to use feature names to group contexts and remove runtime_enabled_function_name() function. This CL does not change generated code. BUG=None Committed: https://crrev.com/9aa18b4eace75d3c11686ce1c030d8511891d914 Cr-Commit-Position: refs/heads/master@{#439088}

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : Work for a comment #

Messages

Total messages: 21 (13 generated)
peria
PTL
4 years ago (2016-12-15 10:04:27 UTC) #4
haraken
LGTM
4 years ago (2016-12-15 11:38:24 UTC) #9
Yuki
https://codereview.chromium.org/2578943002/diff/20001/third_party/WebKit/Source/bindings/scripts/v8_attributes.py File third_party/WebKit/Source/bindings/scripts/v8_attributes.py (right): https://codereview.chromium.org/2578943002/diff/20001/third_party/WebKit/Source/bindings/scripts/v8_attributes.py#newcode183 third_party/WebKit/Source/bindings/scripts/v8_attributes.py:183: 'runtime_enabled': v8_utilities.runtime_feature_name(attribute), # [RuntimeEnabled] nit: 'runtime_enabled' sounds to me ...
4 years ago (2016-12-15 11:56:39 UTC) #10
peria
https://codereview.chromium.org/2578943002/diff/20001/third_party/WebKit/Source/bindings/scripts/v8_attributes.py File third_party/WebKit/Source/bindings/scripts/v8_attributes.py (right): https://codereview.chromium.org/2578943002/diff/20001/third_party/WebKit/Source/bindings/scripts/v8_attributes.py#newcode183 third_party/WebKit/Source/bindings/scripts/v8_attributes.py:183: 'runtime_enabled': v8_utilities.runtime_feature_name(attribute), # [RuntimeEnabled] On 2016/12/15 11:56:39, Yuki wrote: ...
4 years ago (2016-12-16 05:27:04 UTC) #12
Yuki
LGTM.
4 years ago (2016-12-16 06:25:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578943002/60001
4 years ago (2016-12-16 09:29:38 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years ago (2016-12-16 11:21:26 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-16 11:23:29 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9aa18b4eace75d3c11686ce1c030d8511891d914
Cr-Commit-Position: refs/heads/master@{#439088}

Powered by Google App Engine
This is Rietveld 408576698