third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl - Issue 2578943002: [Bindings] Refactoring of binding code around runtime enabled features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

Issue 2578943002: [Bindings] Refactoring of binding code around runtime enabled features (Closed)

Patch Set: Work for a comment Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

index 05dfe6b542224d4e5e0f4f1e8e481366f462d2fa..e1480637e527dee214e8662d1c8de61036d0f662 100644

--- a/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl

@@ -44,7 +44,7 @@ void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{

}

{% endif %}

{% for member in members %}

- {% filter runtime_enabled(member.runtime_enabled_function) %}

+ {% filter runtime_enabled(member.runtime_enabled_feature_name) %}

v8::Local<v8::Value> {{member.name}}Value;

if (!v8Object->Get(isolate->GetCurrentContext(), v8String(isolate, "{{member.name}}")).ToLocal(&{{member.name}}Value)) {

exceptionState.rethrowV8Exception(block.Exception());