Converts chrome to aura-mus

Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932
663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381
Committed: https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681
Cr-Original-Commit-Position: refs/heads/master@{#439044}
Cr-Commit-Position: refs/heads/master@{#439201}

[sky, 2016-12-15 16:33:44]

reveman: exo
sadrul: the rest

[sky, 2016-12-15 16:33:53]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 16:34:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 18:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 18:00:29]

Dry run: This issue passed the CQ dry run.

[reveman, 2016-12-16 01:35:03]

components/exo lgtm

[sadrul, 2016-12-16 02:17:48]

LGTM

https://codereview.chromium.org/2578893003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc (right):

https://codereview.chromium.org/2578893003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc:357:
GetWidget()->GetNativeWindow()->GetHost())
We are using this static-cast in a few places. Maybe we could have some
DesktopWindowTreeHostMus::FromWidget() or something instead?

https://codereview.chromium.org/2578893003/diff/40001/ui/aura/mus/focus_synch...
File ui/aura/mus/focus_synchronizer.h (right):

https://codereview.chromium.org/2578893003/diff/40001/ui/aura/mus/focus_synch...
ui/aura/mus/focus_synchronizer.h:69: // Cached so we can detect if Env is
destroyed before us.
When does this happen?

[sky, 2016-12-16 03:51:51]

https://codereview.chromium.org/2578893003/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc (right):

https://codereview.chromium.org/2578893003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc:357:
GetWidget()->GetNativeWindow()->GetHost())
On 2016/12/16 02:17:48, sadrul wrote:
> We are using this static-cast in a few places. Maybe we could have some
> DesktopWindowTreeHostMus::FromWidget() or something instead?

I'm hesitant to do that because it's generally not safe. Place like this it's ok
because they know what the Host is.

https://codereview.chromium.org/2578893003/diff/40001/ui/aura/mus/focus_synch...
File ui/aura/mus/focus_synchronizer.h (right):

https://codereview.chromium.org/2578893003/diff/40001/ui/aura/mus/focus_synch...
ui/aura/mus/focus_synchronizer.h:69: // Cached so we can detect if Env is
destroyed before us.
On 2016/12/16 02:17:48, sadrul wrote:
> When does this happen?

It appears content destroys Env before the WindowTreeclient is destroyed. That
is likely error prone. I'll file a bug on it.

[sky, 2016-12-16 03:52:09]

The CQ bit was checked by sky@chromium.org

[sky, 2016-12-16 03:52:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2578893003/#ps60001
(title: "todo")

[commit-bot: I haz the power, 2016-12-16 03:53:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 06:17:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481860329373750,
"parent_rev": "4f41f96c59ca7b0d3d9c2d41db407335fe9e2103", "commit_rev":
"f7d6954eeeaeb739dae4106476dde9c7b639c813"}

[commit-bot: I haz the power, 2016-12-16 06:18:09]

Description was changed from

==========
Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org
==========

to

==========
Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2578893003
==========

[commit-bot: I haz the power, 2016-12-16 06:18:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-16 06:21:14]

Description was changed from

==========
Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2578893003
==========

to

==========
Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381
Cr-Commit-Position: refs/heads/master@{#439044}
==========

[commit-bot: I haz the power, 2016-12-16 06:21:15]

Patchset 4 (id:??) landed as
https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381
Cr-Commit-Position: refs/heads/master@{#439044}

[Kunihiko Sakamoto, 2016-12-16 07:59:50]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2577963006/ by ksakamoto@chromium.org.

The reason for reverting is: Broke Linux ChromiumOS Builder (dbg) build.
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

[sky, 2016-12-16 17:00:12]

Description was changed from

==========
Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381
Cr-Commit-Position: refs/heads/master@{#439044}
==========

to

==========
Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381
Cr-Commit-Position: refs/heads/master@{#439044}
==========

[sky, 2016-12-16 17:02:29]

On 2016/12/16 07:59:50, Kunihiko Sakamoto wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2577963006/ by mailto:ksakamoto@chromium.org.
> 
> The reason for reverting is: Broke Linux ChromiumOS Builder (dbg) build.
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

The compile failure was in ui_arc_unittests as components/exo needs a dep on
cc/ipc:interfaces. I'm not sure why gn check failed (or why a builder didn't
pick it up). I can only guess previously this worked because of the dep on
//services/ui/public/cpp that I removed.

[sky, 2016-12-16 17:02:37]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[sky, 2016-12-16 17:02:55]

Diff between patchsets 5 and 6 to see the change to BUILD.gn

[sky, 2016-12-16 17:02:58]

Diff between patchsets 5 and 6 to see the change to BUILD.gn

[commit-bot: I haz the power, 2016-12-16 17:03:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2016-12-16 17:05:37]

lgtm

[sky, 2016-12-16 17:07:20]

The CQ bit was checked by sky@chromium.org

[sky, 2016-12-16 17:07:20]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2578893003/#ps100001
(title: "fix")

[commit-bot: I haz the power, 2016-12-16 17:07:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 18:08:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 18:08:39]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sky, 2016-12-16 18:15:53]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-12-16 18:16:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 18:24:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 18:24:41]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[sky, 2016-12-16 18:27:24]

The CQ bit was checked by sky@chromium.org

[sky, 2016-12-16 18:27:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2578893003/#ps120001
(title: "merge again")

[commit-bot: I haz the power, 2016-12-16 18:28:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 21:52:28]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481912844217450,
"parent_rev": "0e2616e1885f93656aa3ae0bdac80c29093c8944", "commit_rev":
"8de440d2070683fee7bc37ee53f372b84b99853e"}

[commit-bot: I haz the power, 2016-12-16 21:52:54]

Description was changed from

==========
Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381
Cr-Commit-Position: refs/heads/master@{#439044}
==========

to

==========
Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381
Cr-Commit-Position: refs/heads/master@{#439044}
Review-Url: https://codereview.chromium.org/2578893003
==========

[commit-bot: I haz the power, 2016-12-16 21:52:55]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-16 21:55:59]

Description was changed from

==========
Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381
Cr-Commit-Position: refs/heads/master@{#439044}
Review-Url: https://codereview.chromium.org/2578893003
==========

to

==========
Converts chrome to aura-mus

aura-mus has a different environment than mus, so WMHelperMus (in exo)
was updated accordingly.

This breaks switches::kUseMusInRenderer. I'll fix that next.

BUG=672932 663525
TEST=covered by tests
R=reveman@chromium.org, sadrul@chromium.org

Committed: https://crrev.com/e3e1ea3c0699e70c8ca5a6a790641c58be4e1381
Committed: https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681
Cr-Original-Commit-Position: refs/heads/master@{#439044}
Cr-Commit-Position: refs/heads/master@{#439201}
==========

[commit-bot: I haz the power, 2016-12-16 21:56:01]

Patchset 7 (id:??) landed as
https://crrev.com/cea631eaeaa21f4a0865cbb2d6f6a51535509681
Cr-Commit-Position: refs/heads/master@{#439201}

[Peng, 2017-01-03 20:15:37]

penghuang@chromium.org changed reviewers:
+ penghuang@chromium.org

[Peng, 2017-01-03 20:15:38]

https://codereview.chromium.org/2578893003/diff/120001/chrome/app/chrome_main.cc
File chrome/app/chrome_main.cc (right):

https://codereview.chromium.org/2578893003/diff/120001/chrome/app/chrome_main...
chrome/app/chrome_main.cc:108: params.env_mode = aura::Env::Mode::MUS;
This change breaks exo in mus. The exo crashes at [1]. Sky, do you have any idea
how to fix it?


[1]
https://cs.chromium.org/chromium/src/components/exo/shell_surface.cc?rcl=0&l=838

[24848:24848:0103/151250.080451:FATAL:wm_window_aura.cc(104)] Check failed:
aura::Env::Mode::LOCAL == aura::Env::GetInstance()->mode() (0 vs. 1)
#0 0x2b02254b1bde base::debug::StackTrace::StackTrace()
#1 0x2b02254d25ba logging::LogMessage::~LogMessage()
#2 0x2b022af09a1e ash::WmWindowAura::Get()
#3 0x2b022b0518af ash::wm::GetWindowState()
#4 0x2b02222061a8 exo::ShellSurface::CreateNonClientFrameView()
#5 0x2b02222062ea exo::ShellSurface::CreateNonClientFrameView()
#6 0x2b02297e7dea views::Widget::CreateNonClientFrameView()
#7 0x2b02297e5c3c views::Widget::Init()
#8 0x2b022220324c exo::ShellSurface::CreateShellSurfaceWidget()
#9 0x2b0222205828 exo::ShellSurface::OnSurfaceCommit()
#10 0x2b022220aeb1 exo::Surface::Commit()
#11 0x2b022d90dadc ffi_call_unix64
#12 0x2b022d90d40c ffi_call
#13 0x2b02239a2477 wl_closure_invoke
#14 0x2b02239a0280 wl_client_connection_data
#15 0x2b022399f982 wl_event_loop_dispatch
#16 0x2b02222fc64d exo::wayland::Server::Dispatch()
#17 0x2b022264676f
ChromeBrowserMainExtraPartsExo::WaylandWatcher::OnFileCanReadWithoutBlocking()
#18 0x2b02254e2041 base::MessagePumpLibevent::OnLibeventNotification()
#19 0x2b0225596627 event_base_loop
#20 0x2b02254e2306 base::MessagePumpLibevent::Run()
#21 0x2b02254df2ab base::MessageLoop::RunHandler()
#22 0x2b022550ef5f base::RunLoop::Run()
#23 0x2b0222445dd3 ChromeBrowserMainParts::MainMessageLoopRun()
#24 0x2b0227393b43 content::BrowserMainLoop::RunMainMessageLoopParts()
#25 0x2b02273968aa content::BrowserMainRunnerImpl::Run()
#26 0x2b022738ee78 content::BrowserMain()
#27 0x2b0227ae9ffc content::ContentMainRunnerImpl::Run()
#28 0x2b0227ae8b30 content::ContentMain()
#29 0x2b0221b971e0 ChromeMain
#30 0x2b022e0e5f45 __libc_start_main
#31 0x2b0221b9701d <unknown>

[sadrul, 2017-01-03 20:19:31]

https://codereview.chromium.org/2578893003/diff/120001/chrome/app/chrome_main.cc
File chrome/app/chrome_main.cc (right):

https://codereview.chromium.org/2578893003/diff/120001/chrome/app/chrome_main...
chrome/app/chrome_main.cc:108: params.env_mode = aura::Env::Mode::MUS;
On 2017/01/03 20:15:38, Peng wrote:
> This change breaks exo in mus. The exo crashes at [1]. Sky, do you have any
idea
> how to fix it?
> 
> 
> [1]
>
https://cs.chromium.org/chromium/src/components/exo/shell_surface.cc?rcl=0&l=838
> 
> [24848:24848:0103/151250.080451:FATAL:wm_window_aura.cc(104)] Check failed:
> aura::Env::Mode::LOCAL == aura::Env::GetInstance()->mode() (0 vs. 1)
> #0 0x2b02254b1bde base::debug::StackTrace::StackTrace()
> #1 0x2b02254d25ba logging::LogMessage::~LogMessage()
> #2 0x2b022af09a1e ash::WmWindowAura::Get()
> #3 0x2b022b0518af ash::wm::GetWindowState()

Looks like exo is trying to use ash? We need to make sure that does not happen.
(since ash is in a separate process)

How did it work before this change?

> #4 0x2b02222061a8 exo::ShellSurface::CreateNonClientFrameView()
> #5 0x2b02222062ea exo::ShellSurface::CreateNonClientFrameView()
> #6 0x2b02297e7dea views::Widget::CreateNonClientFrameView()
> #7 0x2b02297e5c3c views::Widget::Init()
> #8 0x2b022220324c exo::ShellSurface::CreateShellSurfaceWidget()
> #9 0x2b0222205828 exo::ShellSurface::OnSurfaceCommit()
> #10 0x2b022220aeb1 exo::Surface::Commit()
> #11 0x2b022d90dadc ffi_call_unix64
> #12 0x2b022d90d40c ffi_call
> #13 0x2b02239a2477 wl_closure_invoke
> #14 0x2b02239a0280 wl_client_connection_data
> #15 0x2b022399f982 wl_event_loop_dispatch
> #16 0x2b02222fc64d exo::wayland::Server::Dispatch()
> #17 0x2b022264676f
> ChromeBrowserMainExtraPartsExo::WaylandWatcher::OnFileCanReadWithoutBlocking()
> #18 0x2b02254e2041 base::MessagePumpLibevent::OnLibeventNotification()
> #19 0x2b0225596627 event_base_loop
> #20 0x2b02254e2306 base::MessagePumpLibevent::Run()
> #21 0x2b02254df2ab base::MessageLoop::RunHandler()
> #22 0x2b022550ef5f base::RunLoop::Run()
> #23 0x2b0222445dd3 ChromeBrowserMainParts::MainMessageLoopRun()
> #24 0x2b0227393b43 content::BrowserMainLoop::RunMainMessageLoopParts()
> #25 0x2b02273968aa content::BrowserMainRunnerImpl::Run()
> #26 0x2b022738ee78 content::BrowserMain()
> #27 0x2b0227ae9ffc content::ContentMainRunnerImpl::Run()
> #28 0x2b0227ae8b30 content::ContentMain()
> #29 0x2b0221b971e0 ChromeMain
> #30 0x2b022e0e5f45 __libc_start_main
> #31 0x2b0221b9701d <unknown>