Converts chrome to aura-mus

chrome/app/chrome_main.cc

Index: chrome/app/chrome_main.cc
diff --git a/chrome/app/chrome_main.cc b/chrome/app/chrome_main.cc
index 8e1dcc577a1b9bba422497d3618a3fd91333c4ca..5d63c3b6f639ebb203b0ec376825c5577f6ffe73 100644
--- a/chrome/app/chrome_main.cc
+++ b/chrome/app/chrome_main.cc
@@ -18,6 +18,7 @@
 #include "chrome/app/mash/mash_runner.h"
 #include "chrome/common/channel_info.h"
 #include "components/version_info/version_info.h"
+#include "services/service_manager/runner/common/client_util.h"
 #endif
 
 #if defined(OS_WIN)
@@ -103,6 +104,8 @@ int ChromeMain(int argc, const char** argv) {
     if (command_line->HasSwitch("mash"))
       return MashMain();
     WaitForMashDebuggerIfNecessary();
+    if (service_manager::ServiceManagerIsRemote())
+      params.env_mode = aura::Env::Mode::MUS;

[Peng, 2017/01/03 20:15:38]

This change breaks exo in mus. The exo crashes at [1]. Sky, do you have any idea
how to fix it?


[1]
https://cs.chromium.org/chromium/src/components/exo/shell_surface.cc?rcl=0&l=838

[24848:24848:0103/151250.080451:FATAL:wm_window_aura.cc(104)] Check failed:
aura::Env::Mode::LOCAL == aura::Env::GetInstance()->mode() (0 vs. 1)
#0 0x2b02254b1bde base::debug::StackTrace::StackTrace()
#1 0x2b02254d25ba logging::LogMessage::~LogMessage()
#2 0x2b022af09a1e ash::WmWindowAura::Get()
#3 0x2b022b0518af ash::wm::GetWindowState()
#4 0x2b02222061a8 exo::ShellSurface::CreateNonClientFrameView()
#5 0x2b02222062ea exo::ShellSurface::CreateNonClientFrameView()
#6 0x2b02297e7dea views::Widget::CreateNonClientFrameView()
#7 0x2b02297e5c3c views::Widget::Init()
#8 0x2b022220324c exo::ShellSurface::CreateShellSurfaceWidget()
#9 0x2b0222205828 exo::ShellSurface::OnSurfaceCommit()
#10 0x2b022220aeb1 exo::Surface::Commit()
#11 0x2b022d90dadc ffi_call_unix64
#12 0x2b022d90d40c ffi_call
#13 0x2b02239a2477 wl_closure_invoke
#14 0x2b02239a0280 wl_client_connection_data
#15 0x2b022399f982 wl_event_loop_dispatch
#16 0x2b02222fc64d exo::wayland::Server::Dispatch()
#17 0x2b022264676f
ChromeBrowserMainExtraPartsExo::WaylandWatcher::OnFileCanReadWithoutBlocking()
#18 0x2b02254e2041 base::MessagePumpLibevent::OnLibeventNotification()
#19 0x2b0225596627 event_base_loop
#20 0x2b02254e2306 base::MessagePumpLibevent::Run()
#21 0x2b02254df2ab base::MessageLoop::RunHandler()
#22 0x2b022550ef5f base::RunLoop::Run()
#23 0x2b0222445dd3 ChromeBrowserMainParts::MainMessageLoopRun()
#24 0x2b0227393b43 content::BrowserMainLoop::RunMainMessageLoopParts()
#25 0x2b02273968aa content::BrowserMainRunnerImpl::Run()
#26 0x2b022738ee78 content::BrowserMain()
#27 0x2b0227ae9ffc content::ContentMainRunnerImpl::Run()
#28 0x2b0227ae8b30 content::ContentMain()
#29 0x2b0221b971e0 ChromeMain
#30 0x2b022e0e5f45 __libc_start_main
#31 0x2b0221b9701d <unknown>

[sadrul, 2017/01/03 20:19:31]

Looks like exo is trying to use ash? We need to make sure that does not happen.
(since ash is in a separate process)

How did it work before this change?

   }
 #endif  // BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)