Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

BUG=671080, 674434
TEST=manually tested by modifying chrome.storage API to return errors and
confirming that Files app works properly with default options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/26defffaca3b257fae0f625d04fc14724fc71682
Cr-Commit-Position: refs/heads/master@{#438806}

[fukino, 2016-12-15 08:09:24]

Description was changed from

==========
Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

BUG=674434
TEST=manually tested by modifying chrome.storage API to return errors and
confirming that Files app works properly with default options.
==========

to

==========
Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

BUG=674434
TEST=manually tested by modifying chrome.storage API to return errors and
confirming that Files app works properly with default options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-15 08:09:51]

fukino@chromium.org changed reviewers:
+ oka@chromium.org

[fukino, 2016-12-15 08:09:52]

PTAL

[oka, 2016-12-15 09:02:16]

https://codereview.chromium.org/2578863003/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/2578863003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/util.js:392: console.error('Failed to
save app state.');
Why don't you output lastError? Ditto for other places checking lastError.

[oka, 2016-12-15 09:02:26]

lgtm

[fukino, 2016-12-15 09:22:29]

Description was changed from

==========
Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

BUG=674434
TEST=manually tested by modifying chrome.storage API to return errors and
confirming that Files app works properly with default options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

BUG=671080,674434
TEST=manually tested by modifying chrome.storage API to return errors and
confirming that Files app works properly with default options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-15 09:24:07]

https://codereview.chromium.org/2578863003/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/common/js/util.js (right):

https://codereview.chromium.org/2578863003/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/common/js/util.js:392: console.error('Failed to
save app state.');
On 2016/12/15 09:02:16, oka wrote:
> Why don't you output lastError? Ditto for other places checking lastError.

Appended lastError.message to error messages. Thanks!

[oka, 2016-12-15 09:26:48]

lgtm

[fukino, 2016-12-15 09:31:04]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-12-15 09:31:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 11:42:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481794264787440,
"parent_rev": "fbb0b572dd3c831e5c279dc2fdd649ad1d0efa5a", "commit_rev":
"3308961257eedb8bfb0b08a4c3989b953cde96a6"}

[commit-bot: I haz the power, 2016-12-15 11:42:39]

Description was changed from

==========
Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

BUG=671080,674434
TEST=manually tested by modifying chrome.storage API to return errors and
confirming that Files app works properly with default options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

BUG=671080,674434
TEST=manually tested by modifying chrome.storage API to return errors and
confirming that Files app works properly with default options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578863003
==========

[commit-bot: I haz the power, 2016-12-15 11:42:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 11:44:50]

Description was changed from

==========
Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

BUG=671080,674434
TEST=manually tested by modifying chrome.storage API to return errors and
confirming that Files app works properly with default options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578863003
==========

to

==========
Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

BUG=671080,674434
TEST=manually tested by modifying chrome.storage API to return errors and
confirming that Files app works properly with default options.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/26defffaca3b257fae0f625d04fc14724fc71682
Cr-Commit-Position: refs/heads/master@{#438806}
==========

[commit-bot: I haz the power, 2016-12-15 11:44:52]

Patchset 3 (id:??) landed as
https://crrev.com/26defffaca3b257fae0f625d04fc14724fc71682
Cr-Commit-Position: refs/heads/master@{#438806}