ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js - Issue 2578863003: Files app: Handle chrome.runtime.lastError for chrome.storage API calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js

Issue 2578863003: Files app: Handle chrome.runtime.lastError for chrome.storage API calls. (Closed)

Patch Set: Append chrome.runtime.lastError.message for error messages. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/app_state_controller.js ('k') | ui/file_manager/file_manager/foreground/js/ui/banners.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js

diff --git a/ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js b/ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js

index 7e842a8aed9b31133e217f6a1baa55dd09db8fdc..7052d8cea9874630569ea1821036dab02401dfa8 100644

--- a/ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js

+++ b/ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js

@@ -191,6 +191,12 @@ FolderShortcutsDataModel.prototype = {

load_: function() {

this.queue_.run(function(callback) {

chrome.storage.sync.get(FolderShortcutsDataModel.NAME, function(value) {

+ if (chrome.runtime.lastError) {

+ console.error('Failed to load shortcut paths from chrome.storage: ' +

+ chrome.runtime.lastError.message);

+ callback();

+ return;

+ }

var shortcutPaths = value[FolderShortcutsDataModel.NAME] || [];

// Record metrics.