Implement Win 10 onboarding content logic

chrome/browser/ui/startup/startup_tab_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/startup_tab_provider.h"
 
 #include "build/build_config.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/profile_resetter/triggered_profile_resetter.h"
 #include "chrome/browser/profile_resetter/triggered_profile_resetter_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/tabs/pinned_tab_codec.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/locale_settings.h"
 #include "components/prefs/pref_service.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "net/base/url_util.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_WIN)
 #include "base/win/windows_version.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/shell_integration.h"
 #endif
 
 StartupTabs StartupTabProviderImpl::GetOnboardingTabs(Profile* profile) const {
+  if (!profile)
+    return StartupTabs();
+
 #if defined(OS_WIN)
   // Windows 10 has unique onboarding policies and content.
   if (base::win::GetVersion() >= base::win::VERSION_WIN10) {
-    // TODO(tmartino): * Add a function, GetWin10SystemState, which gathers
-    //                   system state relevant to Win10 Onboarding and returns
-    //                   a struct.
-    //                 * Add a function, CheckWin10OnboardingTabPolicy, which
-    //                   takes such a struct as input and returns StartupTabs.
-    return StartupTabs();
+    PrefService* prefs = profile->GetPrefs();
+    bool has_seen_welcome_page =

[tmartino, 2016/12/15 16:41:28]

Let's define and populate has_seen_welcome_page, is_signed_in, and is_first_run
outside the #ifdef block, so that we don't duplicate that code. Those state
checks work for both calls.

[Patrick Monette, 2016/12/15 18:28:09]

Done.

+        prefs && prefs->GetBoolean(prefs::kHasSeenWelcomePage);
+    bool has_seen_win10_promo =
+        prefs && prefs->GetBoolean(prefs::kHasSeenWin10PromoPage);
+    SigninManagerBase* signin_manager =
+        SigninManagerFactory::GetForProfile(profile);
+    bool is_signed_in = signin_manager && signin_manager->IsAuthenticated();
+    bool is_default_browser =
+        g_browser_process->CachedDefaultWebClientState() ==
+        shell_integration::IS_DEFAULT;
+    return CheckWin10OnboardingTabPolicy(
+        first_run::IsChromeFirstRun(), has_seen_welcome_page,
+        has_seen_win10_promo, is_signed_in, is_default_browser);
   }
 #endif
 
-  if (!profile)
-    return StartupTabs();
-
   PrefService* prefs = profile->GetPrefs();
   bool has_seen_welcome_page =
       prefs && prefs->GetBoolean(prefs::kHasSeenWelcomePage);
   SigninManagerBase* signin_manager =
       SigninManagerFactory::GetForProfile(profile);
   bool is_signed_in = signin_manager && signin_manager->IsAuthenticated();
   return CheckStandardOnboardingTabPolicy(first_run::IsChromeFirstRun(),
                                           has_seen_welcome_page, is_signed_in);
 }
 
@@ skipping 42 matching lines @@
 StartupTabs StartupTabProviderImpl::CheckStandardOnboardingTabPolicy(
     bool is_first_run,
     bool has_seen_welcome_page,
     bool is_signed_in) {
   StartupTabs tabs;
   if (!has_seen_welcome_page && !is_signed_in)
     tabs.emplace_back(GetWelcomePageUrl(!is_first_run), false);
   return tabs;
 }
 
+#if defined(OS_WIN)
+// static
+StartupTabs StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
+    bool is_first_run,
+    bool has_seen_welcome_page,
+    bool has_seen_win10_promo,
+    bool is_signed_in,
+    bool is_default_browser) {
+  StartupTabs tabs;
+  if (!has_seen_win10_promo && !is_default_browser)
+    tabs.emplace_back(GetWin10WelcomePageUrl(!is_first_run), false);
+  else if (!has_seen_welcome_page && !is_signed_in)
+    tabs.emplace_back(GetWelcomePageUrl(!is_first_run), false);
+  return tabs;
+}
+#endif
+
 // static
 StartupTabs StartupTabProviderImpl::CheckMasterPrefsTabPolicy(
     bool is_first_run,
     const std::vector<GURL>& first_run_tabs) {
   // Constants: Magic words used by Master Preferences files in place of a URL
   // host to indicate that internal pages should appear on first run.
   static constexpr char kNewTabUrlHost[] = "new_tab_page";
   static constexpr char kWelcomePageUrlHost[] = "welcome_page";
 
   StartupTabs tabs;
@@ skipping 48 matching lines @@
 }
 
 // static
 GURL StartupTabProviderImpl::GetWelcomePageUrl(bool use_later_run_variant) {
   GURL url(chrome::kChromeUIWelcomeURL);
   return use_later_run_variant
              ? net::AppendQueryParameter(url, "variant", "everywhere")
              : url;
 }
 
+#if defined(OS_WIN)
+// static
+GURL StartupTabProviderImpl::GetWin10WelcomePageUrl(
+    bool use_later_run_variant) {
+  GURL url(chrome::kChromeUIWelcomeWin10URL);
+  return use_later_run_variant
+             ? net::AppendQueryParameter(url, "text", "faster")
+             : url;
+}
+#endif
+
 // static
 GURL StartupTabProviderImpl::GetTriggeredResetSettingsUrl() {
   return GURL(
       chrome::GetSettingsUrl(chrome::kTriggeredResetProfileSettingsSubPage));
 }