MD Settings: Fix size and padding of expand button

MD Settings: Fix size and padding of expand button

This CL includes some cleanup to make the vars used for icon padding
consistent between cr_elements and settings UI.

BUG=674451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea
Cr-Commit-Position: refs/heads/master@{#439531}

[stevenjb, 2016-12-16 18:56:15]

Description was changed from

==========
MD Settings: Fix size and padding of expand button

This CL includes some cleanup to make the vars used for icon padding
consistent between cr_elements and settings UI.

BUG=674451
==========

to

==========
MD Settings: Fix size and padding of expand button

This CL includes some cleanup to make the vars used for icon padding
consistent between cr_elements and settings UI.

BUG=674451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-12-16 22:09:12]

stevenjb@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dschuyler, 2016-12-16 22:41:41]

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:29:
@apply(--cr-icon-height-width);
Is having a literal name->contents desired?  i.e. if a third thing were added
would the name change?

The -size suffix appears better than -height-width to me on first glance. Could
you tell me more about why this name is better so I 'get-it'?

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_summary_item.js
(left):

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary_item.js:80: },
It's not clear to me why this is being removed. Is this a whoops or is this not
wanted anymore?

[stevenjb, 2016-12-16 22:56:11]

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:29:
@apply(--cr-icon-height-width);
On 2016/12/16 22:41:41, dschuyler wrote:
> Is having a literal name->contents desired?  i.e. if a third thing were added
> would the name change?
> 
> The -size suffix appears better than -height-width to me on first glance.
Could
> you tell me more about why this name is better so I 'get-it'? 

As I'm sure you've now noticed we use 'size' for the actual value that width and
height share. I am open to naming alternatives.

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_summary_item.js
(left):

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary_item.js:80: },
On 2016/12/16 22:41:41, dschuyler wrote:
> It's not clear to me why this is being removed. Is this a whoops or is this
not
> wanted anymore?

It's unwanted and is actually causing the button to not work with 'enter' (it
exists from when we were focusing the entire item). I can remove it separately
if you prefer. I just happened to notice it while testing the rest of this
change.

[dschuyler, 2016-12-17 01:13:54]

lgtm

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:29:
@apply(--cr-icon-height-width);
On 2016/12/16 22:56:10, stevenjb wrote:
> On 2016/12/16 22:41:41, dschuyler wrote:
> > Is having a literal name->contents desired?  i.e. if a third thing were
added
> > would the name change?
> > 
> > The -size suffix appears better than -height-width to me on first glance.
> Could
> > you tell me more about why this name is better so I 'get-it'? 
> 
> As I'm sure you've now noticed we use 'size' for the actual value that width
and
> height share. I am open to naming alternatives.

I don't know, maybe -dimensions or -area. That might not be better. I think
-size is ok as an option too. I see what you're saying and don't want the CL to
get stuck on a variable name.

(I tried MW Thesaurus on dimensions and one option was bailiwick, kinda
tempting).

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_summary_item.js
(left):

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_summary_item.js:80: },
On 2016/12/16 22:56:10, stevenjb wrote:
> On 2016/12/16 22:41:41, dschuyler wrote:
> > It's not clear to me why this is being removed. Is this a whoops or is this
> not
> > wanted anymore?
> 
> It's unwanted and is actually causing the button to not work with 'enter' (it
> exists from when we were focusing the entire item). I can remove it separately
> if you prefer. I just happened to notice it while testing the rest of this
> change.

It's good. I just wanted to ask in case it was a whoops.

[stevenjb, 2016-12-19 18:20:21]

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
(right):

https://codereview.chromium.org/2578793004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html:29:
@apply(--cr-icon-height-width);
On 2016/12/17 01:13:54, dschuyler wrote:
> On 2016/12/16 22:56:10, stevenjb wrote:
> > On 2016/12/16 22:41:41, dschuyler wrote:
> > > Is having a literal name->contents desired?  i.e. if a third thing were
> added
> > > would the name change?
> > > 
> > > The -size suffix appears better than -height-width to me on first glance.
> > Could
> > > you tell me more about why this name is better so I 'get-it'? 
> > 
> > As I'm sure you've now noticed we use 'size' for the actual value that width
> and
> > height share. I am open to naming alternatives.
> 
> I don't know, maybe -dimensions or -area. That might not be better. I think
> -size is ok as an option too. I see what you're saying and don't want the CL
to
> get stuck on a variable name.
> 
> (I tried MW Thesaurus on dimensions and one option was bailiwick, kinda
> tempting).

--cr-icon-size = 8px
--cr-icon-height-width = { height: var(--cr-icon-size); width:
var(--cr-icon-size); }

Otherwise I would have stuck with -size.

If we add properties to --cr-icon-height-width, then we should rename it, but I
suspect we won't. I agree that the name is not great.

[stevenjb, 2016-12-19 18:20:24]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2016-12-19 18:20:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 20:01:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482171624951230,
"parent_rev": "1265fd3e02400b8c2229abd7d2e35beabcdcad2a", "commit_rev":
"ed97aba2de732d2eaffa30b2dab9f301c300a235"}

[commit-bot: I haz the power, 2016-12-19 20:03:39]

Description was changed from

==========
MD Settings: Fix size and padding of expand button

This CL includes some cleanup to make the vars used for icon padding
consistent between cr_elements and settings UI.

BUG=674451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix size and padding of expand button

This CL includes some cleanup to make the vars used for icon padding
consistent between cr_elements and settings UI.

BUG=674451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578793004
Committed:
https://chromium.googlesource.com/chromium/src/+/ed97aba2de732d2eaffa30b2dab9...
==========

[commit-bot: I haz the power, 2016-12-19 20:03:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ed97aba2de732d2eaffa30b2dab9...

[commit-bot: I haz the power, 2016-12-19 20:05:30]

Description was changed from

==========
MD Settings: Fix size and padding of expand button

This CL includes some cleanup to make the vars used for icon padding
consistent between cr_elements and settings UI.

BUG=674451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578793004
Committed:
https://chromium.googlesource.com/chromium/src/+/ed97aba2de732d2eaffa30b2dab9...
==========

to

==========
MD Settings: Fix size and padding of expand button

This CL includes some cleanup to make the vars used for icon padding
consistent between cr_elements and settings UI.

BUG=674451
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea
Cr-Commit-Position: refs/heads/master@{#439531}
==========

[commit-bot: I haz the power, 2016-12-19 20:05:31]

Patchset 2 (id:??) landed as
https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea
Cr-Commit-Position: refs/heads/master@{#439531}